Reported by portscout
- Create pkg-plist instead of PLIST
- Remove do-install and let the patched Makefile's install target do the job.
- Add asciidoc as dependency since the man pages changed format
Details
Details
- Reviewers
tz tcberner - Commits
- rP469833: Update graphics/imv to 3.0.0
- portlint -AC OK
- poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
- Run test in 11.1 OK.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 16558 Build 16472: arc lint + arc unit
Event Timeline
Comment Actions
Why did you change it to a plist?
| graphics/imv/pkg-plist | ||
|---|---|---|
| 2 ↗ | (On Diff #42435) | ^ this is wrong |
Comment Actions
I'm including two more files to the list. I didn't want to abuse PLIST. There's nothing in the porter's book about the recommended length of the list but I can change it again :)
| graphics/imv/pkg-plist | ||
|---|---|---|
| 2 ↗ | (On Diff #42435) | Wow. Sorry for that. I looks pretty broken. It was auto-generated by make makeplist. |
Comment Actions
It is back now. I will try to know why make makeplist messes the path for imv_config and why poudriere doesn't detect the problem.
Comment Actions
Don't worry, it would have worked as ETCDIR expands to the string you need. So functionally it was fine,... Still not correct though
It's not messed up, it's just a wrongly used substitution :) -- ETCDIR expands to etc/${PORTNAME}. -- so
%%ETCDIR%% = etc/imv in this case.
Now make-plist sees "etc/imv_config" and is greedy and replaces the occurence of etc/imv by ETCDIR.
So, in short, the plist would have worked with %%ETCDIR%% -- it's just not correct :)
| graphics/imv/Makefile | ||
|---|---|---|
| 17 | ^ Wrong order BUILD, LIB, TEST. | |