Update graphics/imv to 3.0.0

[fernape]

Summary

Reported by portscout

• Create pkg-plist instead of PLIST
• Remove do-install and let the patched Makefile's install target do the job.
• Add asciidoc as dependency since the man pages changed format

Test Plan

• portlint -AC OK
• poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
• Run test in 11.1 OK.

[tcberner]

Why did you change it to a plist?

graphics/imv/pkg-plist

2 ↗

(On Diff #42435)

^ this is wrong

[fernape]

Fixing pkg-plist.

[fernape]

In D15397#324747, @tcberner wrote:

Why did you change it to a plist?

I'm including two more files to the list. I didn't want to abuse PLIST. There's nothing in the porter's book about the recommended length of the list but I can change it again :)

graphics/imv/pkg-plist

2 ↗

(On Diff #42435)

Wow. Sorry for that. I looks pretty broken. It was auto-generated by make makeplist.
It's fixed now.

[tcberner]

I would keep it in the Makefile.

[fernape]

Bring PLIST_FILES back

[fernape]

In D15397#324758, @tcberner wrote:

I would keep it in the Makefile.

It is back now. I will try to know why make makeplist messes the path for imv_config and why poudriere doesn't detect the problem.

[tcberner]

Don't worry, it would have worked as ETCDIR expands to the string you need. So functionally it was fine,... Still not correct though

In D15397#324850, @fernape wrote:

In D15397#324758, @tcberner wrote:

I would keep it in the Makefile.

It is back now. I will try to know why make makeplist messes the path for imv_config and why poudriere doesn't detect the problem.

It's not messed up, it's just a wrongly used substitution :) -- ETCDIR expands to etc/${PORTNAME}. -- so
%%ETCDIR%% = etc/imv in this case.

Now make-plist sees "etc/imv_config" and is greedy and replaces the occurence of etc/imv by ETCDIR.

So, in short, the plist would have worked with %%ETCDIR%% -- it's just not correct :)

[tcberner]

graphics/imv/Makefile

17

^ Wrong order BUILD, LIB, TEST.

[fernape]

Reorder BUILD and LIB depends.

[fernape]

In D15397#324926, @tcberner wrote:

Don't worry, it would have worked as ETCDIR expands to the string you need. So functionally it was fine,... Still not correct though

In D15397#324850, @fernape wrote:

In D15397#324758, @tcberner wrote:

I would keep it in the Makefile.

It is back now. I will try to know why make makeplist messes the path for imv_config and why poudriere doesn't detect the problem.

It's not messed up, it's just a wrongly used substitution :) -- ETCDIR expands to etc/${PORTNAME}. -- so
%%ETCDIR%% = etc/imv in this case.

Now make-plist sees "etc/imv_config" and is greedy and replaces the occurence of etc/imv by ETCDIR.

So, in short, the plist would have worked with %%ETCDIR%% -- it's just not correct :)

Thanks for the explanation!

[tcberner]

Looks good to me.