Page MenuHomeFreeBSD
Differential D15383

Fix build for platforms using GCC
ClosedPublic
Actions

Authored by lwhsu on May 10 2018, 4:51 PM.
Tags
None
Referenced Files
F164978677: D15383.id42372.diff
Wed, Aug 5, 5:04 AM
Unknown Object (File)
Wed, Jul 29, 7:17 AM
Unknown Object (File)
Mon, Jul 27, 5:21 AM
Unknown Object (File)
Sat, Jul 25, 5:58 PM
Unknown Object (File)
Mon, Jul 20, 1:24 AM
Unknown Object (File)
Sat, Jul 18, 10:26 AM
Unknown Object (File)
Jul 3 2026, 6:38 AM
Unknown Object (File)
Jul 2 2026, 3:13 PM
View All 87 Files
Subscribers
imp
jhibbits

Details

Reviewers
mav
jhibbits
Group Reviewers
cam
Commits
rS360687: Redo r360682, now with only a minimal fix for misleading indentation:
rS360686: Revert r360682, as it does not compile on stable/11 (will commit a
rS360682: MFC r333465 (by lwhsu):
rS333465: Fix build for platforms using GCC:
Summary

Fix build for platforms using GCC:

  • Remove unused or dead store variable
  • Remove unused function ctl_copyin_alloc
  • Add missing curly brackets, this seems a regression in r287720

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16518
Build 16432: arc lint + arc unit

Event Timeline

lwhsu created this revision.May 10 2018, 4:51 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 10 2018, 4:51 PM
Harbormaster completed remote builds in B16518: Diff 42370.May 10 2018, 4:51 PM
lwhsu added inline comments.May 10 2018, 4:54 PM
sys/cam/ctl/ctl.c
8610

I'm not 100% sure about this is right, but I highly suspect it should do so after checking https://svnweb.freebsd.org/base/head/sys/cam/ctl/ctl.c?annotate=333446#l8481

jhibbits accepted this revision.May 10 2018, 5:05 PM
jhibbits added a subscriber: jhibbits.

If it builds, looks good to me.

This revision is now accepted and ready to land.May 10 2018, 5:05 PM
Closed by commit rS333465: Fix build for platforms using GCC: (authored by lwhsu). · Explain WhyMay 10 2018, 5:22 PM
This revision was automatically updated to reflect the committed changes.
dim added a commit: rS360682: MFC r333465 (by lwhsu):.May 6 2020, 5:33 AM
Herald added a reviewer: cam. · View Herald TranscriptMay 6 2020, 5:33 AM
dim added a commit: rS360686: Revert r360682, as it does not compile on stable/11 (will commit a.May 6 2020, 8:24 AM
dim added a commit: rS360687: Redo r360682, now with only a minimal fix for misleading indentation:.May 6 2020, 8:33 AM

Revision Contents
Changeset List

PathSize
sys/
cam/
ctl/
37 lines

Diff 42370

View Options

sys/cam/ctl/ctl.c

Loading...