Page MenuHomeFreeBSD
Differential D15197

Remove compression support from bsdgrep
ClosedPublic
Actions

Authored by bapt on Apr 25 2018, 1:50 PM.
Tags
None
Referenced Files
F149160863: D15197.id.diff
Sun, Mar 22, 4:15 PM
F149051856: D15197.id.diff
Sun, Mar 22, 12:28 AM
F149012907: D15197.id.diff
Sat, Mar 21, 6:34 PM
Unknown Object (File)
Sat, Mar 21, 4:11 PM
Unknown Object (File)
Sat, Mar 21, 4:08 AM
Unknown Object (File)
Thu, Mar 19, 7:59 AM
Unknown Object (File)
Tue, Mar 17, 6:03 AM
Unknown Object (File)
Sun, Mar 8, 8:50 PM
View All Files
Subscribers
imp

Details

Reviewers
kevans
Group Reviewers
manpages
Commits
rS332995: Remove compression support from bsdgrep
Summary

Compression support is now handled by an external script, remove it from the
bsdgrep(1) utility.
This removes the support for -Z -J -X and -M

Note1: that it matches the changes it newer GNU grep

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16304
Build 16245: arc lint + arc unit

Event Timeline

bapt created this revision.Apr 25 2018, 1:50 PM
Herald added a reviewer: manpages. · View Herald TranscriptApr 25 2018, 1:50 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B16303: Diff 41851.Apr 25 2018, 1:50 PM
kevans accepted this revision.Apr 25 2018, 1:53 PM

Looks good to me- we should also re-number the comments on errstr and update the nls/ catalogs, but I'm OK with making a pass to do that after the fact.

This revision is now accepted and ready to land.Apr 25 2018, 1:53 PM
bapt updated this revision to Diff 41852.Apr 25 2018, 1:53 PM

Also remove zlib inclusion

This revision now requires review to proceed.Apr 25 2018, 1:53 PM
Harbormaster completed remote builds in B16304: Diff 41852.Apr 25 2018, 1:53 PM
kevans accepted this revision.Apr 25 2018, 2:04 PM
This revision is now accepted and ready to land.Apr 25 2018, 2:04 PM
Closed by commit rS332995: Remove compression support from bsdgrep (authored by bapt). · Explain WhyApr 25 2018, 2:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
grep/
14 lines
135 lines
4 lines
30 lines
57 lines

Diff 41852

View Options

usr.bin/grep/Makefile

Loading...
View Options

usr.bin/grep/file.c

Loading...
View Options

usr.bin/grep/grep.h

Loading...
View Options

usr.bin/grep/grep.1

Loading...
View Options

usr.bin/grep/grep.c

Loading...