Page MenuHomeFreeBSD
Differential D2046

Fix races during ixl SR-IOV initialization
ClosedPublic
Actions

Authored by rstone on Mar 11 2015, 3:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 13, 1:20 AM
Unknown Object (File)
Jul 16 2025, 9:28 AM
Unknown Object (File)
Jul 15 2025, 4:46 PM
Unknown Object (File)
Jul 7 2025, 8:01 AM
Unknown Object (File)
Jul 4 2025, 5:54 PM
Unknown Object (File)
Jul 3 2025, 3:19 PM
Unknown Object (File)
Jul 1 2025, 2:35 AM
Unknown Object (File)
Jun 27 2025, 9:11 PM
View All Files
Subscribers
ae
imp

Details

Reviewers
jfv
erj
Summary

Fix a number of races during initialization of SR-IOV on ixl:

  • Fix cases that were touching ixl_vf instances before they were initialized
  • I'm seeing issues where adminq interrupts seemingly are never delivered. I haven't been able to get to root cause so instead make sure that the timer is running while SR-IOV is enabled, which has a safety belt for missed adminq interrupts already.
  • Flush register writes that enable/disable interrupts in the SR-IOV code paths.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rstone updated this revision to Diff 4180.Mar 11 2015, 3:04 PM
rstone retitled this revision from to Fix races during ixl SR-IOV initialization.
rstone edited the test plan for this revision. (Show Details)
rstone added reviewers: jfv, erj.
rstone updated this object.
Herald added a subscriber: imp. · View Herald TranscriptMar 11 2015, 3:04 PM
jfv accepted this revision.Mar 11 2015, 4:18 PM
jfv edited edge metadata.
This revision is now accepted and ready to land.Mar 11 2015, 4:18 PM
erj accepted this revision.Mar 11 2015, 4:49 PM
erj edited edge metadata.
erj added a comment.Jun 26 2015, 9:33 PM

Like @D2050, this hasn't made it in yet. Does this need more work or testing?

erj closed this revision.Mar 19 2018, 10:38 PM
Herald added a subscriber: ae. · View Herald TranscriptMar 19 2018, 10:38 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
ixl/
63 lines

Diff 4180

View Options

sys/dev/ixl/if_ixl.c

Loading...