Differential D2046

Fix races during ixl SR-IOV initialization
ClosedPublic
Actions

Authored by rstone on Mar 11 2015, 3:04 PM.

Details

Reviewers

jfv
erj

Summary

Fix a number of races during initialization of SR-IOV on ixl:

Fix cases that were touching ixl_vf instances before they were initialized
I'm seeing issues where adminq interrupts seemingly are never delivered. I haven't been able to get to root cause so instead make sure that the timer is running while SR-IOV is enabled, which has a safety belt for missed adminq interrupts already.
Flush register writes that enable/disable interrupts in the SR-IOV code paths.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rstone updated this revision to Diff 4180.Mar 11 2015, 3:04 PM

rstone retitled this revision from to Fix races during ixl SR-IOV initialization.

rstone edited the test plan for this revision. (Show Details)

rstone added reviewers: jfv, erj.

rstone updated this object.

Herald added a subscriber: imp. · View Herald TranscriptMar 11 2015, 3:04 PM

jfv accepted this revision.Mar 11 2015, 4:18 PM

jfv edited edge metadata.

This revision is now accepted and ready to land.Mar 11 2015, 4:18 PM

erj accepted this revision.Mar 11 2015, 4:49 PM

erj edited edge metadata.

Like @D2050, this hasn't made it in yet. Does this need more work or testing?

erj closed this revision.Mar 19 2018, 10:38 PM

Herald added a subscriber: ae. · View Herald TranscriptMar 19 2018, 10:38 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixl/

if_ixl.c

63 lines

Diff 4180

View Options

sys/dev/ixl/if_ixl.c

Show First 20 Lines • Show All 2,029 Lines • ▼ Show 20 Lines	#endif
tc_windup(NULL);		tc_windup(NULL);
mtx_unlock_spin(&tc_setclock_mtx);		mtx_unlock_spin(&tc_setclock_mtx);
}		}

SYSINIT(timecounter, SI_SUB_CLOCKS, SI_ORDER_SECOND, inittimecounter, NULL);		SYSINIT(timecounter, SI_SUB_CLOCKS, SI_ORDER_SECOND, inittimecounter, NULL);

/* Cpu tick handling -------------------------------------------------*/		/* Cpu tick handling -------------------------------------------------*/

static int cpu_tick_variable;		static bool cpu_tick_variable;
static uint64_t cpu_tick_frequency;		static uint64_t cpu_tick_frequency;

DPCPU_DEFINE_STATIC(uint64_t, tc_cpu_ticks_base);		DPCPU_DEFINE_STATIC(uint64_t, tc_cpu_ticks_base);
DPCPU_DEFINE_STATIC(unsigned, tc_cpu_ticks_last);		DPCPU_DEFINE_STATIC(unsigned, tc_cpu_ticks_last);

static uint64_t		static uint64_t
tc_cpu_ticks(void)		tc_cpu_ticks(void)
{		{
▲ Show 20 Lines • Show All 76 Lines • ▼ Show 20 Lines	if (c_delta > cpu_tick_frequency) {
cpu_tick_frequency = c_delta;		cpu_tick_frequency = c_delta;
}		}
}		}
c_last = c_this;		c_last = c_this;
t_last = t_this;		t_last = t_this;
}		}

void		void
set_cputicker(cpu_tick_f *func, uint64_t freq, unsigned var)		set_cputicker(cpu_tick_f *func, uint64_t freq, bool isvariable)
{		{

if (func == NULL) {		if (func == NULL) {
cpu_ticks = tc_cpu_ticks;		cpu_ticks = tc_cpu_ticks;
} else {		} else {
cpu_tick_frequency = freq;		cpu_tick_frequency = freq;
cpu_tick_variable = var;		cpu_tick_variable = isvariable;
cpu_ticks = func;		cpu_ticks = func;
}		}
}		}

uint64_t		uint64_t
cpu_tickrate(void)		cpu_tickrate(void)
{		{

▲ Show 20 Lines • Show All 117 Lines • Show Last 20 Lines

Fix races during ixl SR-IOV initializationClosedPublicActions