Page MenuHomeFreeBSD
Differential D2023

Address memory leaks in the libc posix1e code found by Coverity.
ClosedPublic
Actions

Authored by pfg on Mar 7 2015, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 3, 5:01 AM
Unknown Object (File)
Fri, Oct 31, 12:36 PM
Unknown Object (File)
Fri, Oct 31, 12:36 PM
Unknown Object (File)
Fri, Oct 31, 12:36 PM
Unknown Object (File)
Fri, Oct 31, 12:36 PM
Unknown Object (File)
Fri, Oct 31, 7:14 AM
Unknown Object (File)
Fri, Oct 31, 7:14 AM
Unknown Object (File)
Fri, Oct 31, 1:50 AM
View All Files
Subscribers
imp

Details

Reviewers
trasz
delphij
rwatson
Commits
rS279962: libc: plug memory leaks in edge cases for the posix1e code.
Summary

These look like memory leaks but I would like confirmation:
CID 1016705
CID 1016706
CID 1016707

Test Plan

Anything with ACLs

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

pfg updated this revision to Diff 4136.Mar 7 2015, 3:20 PM
pfg retitled this revision from to Address memory leaks in the libc posix1e code found by Coverity..
pfg updated this object.
pfg edited the test plan for this revision. (Show Details)
pfg added reviewers: delphij, rwatson, trasz.
Herald added a subscriber: imp. · View Herald TranscriptMar 7 2015, 3:20 PM
trasz added inline comments.Mar 7 2015, 8:16 PM
lib/libc/posix1e/acl_calc_mask.c
107

Shouldn't this be acl_free(acl_new) instead?

126

I know it's not in the patch, but it... looks curious. WTF?

lib/libc/posix1e/acl_strip.c
99

You should also free acl_old, right? Same in the next few cases.

110

... and here, and few below. Might be a good idea to replace all those "return (NULL)" with "goto fail" to avoid code duplication.

pfg added a comment.Mar 7 2015, 9:44 PM

It is quite a mess, I was following blindly what Coverity reported.
I'll update the patch. thanks!

lib/libc/posix1e/acl_calc_mask.c
107

Yes, I got confused by Coverity as it reports acl_int_new is (also) leaked.

126

There's nothing here in "svn diff".

lib/libc/posix1e/acl_strip.c
86

Coverity flags this one because acl_old != NULL from line 78.
It looks like Coverity doesn't know about acl_init().

99

CID 1016705: From line 78 acl_new != NULL.
Coverity doesn't know about acl_get_entry().

pfg updated this revision to Diff 4140.Mar 7 2015, 9:53 PM
This comment was removed by pfg.
pfg updated this revision to Diff 4141.Mar 7 2015, 10:06 PM
This comment was removed by pfg.
pfg updated this revision to Diff 4142.Mar 7 2015, 10:17 PM

It is much cleaner with the "fail" label.
(sorry for the spam)

pfg closed this revision.Mar 13 2015, 6:43 PM
pfg updated this revision to Diff 4214.

Closed by commit rS279962 (authored by @pfg).

Revision Contents
Changeset List

PathSize
lib/
libc/
posix1e/
1 line
14 lines

Diff 4142

View Options

lib/libc/posix1e/acl_calc_mask.c

Loading...
View Options

lib/libc/posix1e/acl_strip.c

Loading...