security/openssh-portable: Regenerate broken patch and fix ssh SSHFP support for non-canonical hostnames
ClosedPublic
Actions

Authored by leres on Apr 12 2018, 8:33 PM.

Details

Reviewers

ler
matthew
bdrewery

Commits

rP467200: The block of code that canonicallizes the hostname supplied on

Summary

Proposed commit message:

The block of code that canonicallizes the hostname supplied on
the command line added by patch-ssh.c misapplies to 7.7p1 and
moves from main() to to ssh_session2(). This breaks ssh SSHFP
support for non-canonical hostnames. For example, "ssh zinc"
correctly discovers the FQDN (zinc.ee.lbl.gov) and uses it to
look up A and AAAA records but the non-canonical version (zinc)
is used in the SSHFP record lookup which or course fails.

Regenerate the patch.

Reviewed by: ? (mentor)
Approved by: bdrewery, ? (mentor)
Differential Revision: ?

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 16121
Build 16076: arc lint + arc unit

Event Timeline

leres created this revision.Apr 12 2018, 8:33 PM

Herald added a subscriber: mat. · View Herald TranscriptApr 12 2018, 8:33 PM

Harbormaster completed remote builds in B16120: Diff 41415.Apr 12 2018, 8:33 PM

Looks good but could you add the header back in from the des commit please? It lets me know I took it from the base patches. Anything above the --- ssh.c.orig line is ignored.