Page MenuHomeFreeBSD
Differential D15053

security/openssh-portable: Regenerate broken patch and fix ssh SSHFP support for non-canonical hostnames
ClosedPublic
Actions

Authored by leres on Apr 12 2018, 8:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 3:09 PM
Unknown Object (File)
Fri, Mar 29, 7:01 AM
Unknown Object (File)
Wed, Mar 27, 7:04 AM
Unknown Object (File)
Mar 24 2024, 6:44 AM
Unknown Object (File)
Mar 16 2024, 4:18 PM
Unknown Object (File)
Mar 16 2024, 4:18 PM
Unknown Object (File)
Mar 16 2024, 4:18 PM
Unknown Object (File)
Mar 16 2024, 4:18 PM
View All 43 Files
Subscribers
bdrewery
mat

Details

Reviewers
ler
matthew
bdrewery
Commits
rP467200: The block of code that canonicallizes the hostname supplied on
Summary

Proposed commit message:

The block of code that canonicallizes the hostname supplied on
the command line added by patch-ssh.c misapplies to 7.7p1 and
moves from main() to to ssh_session2(). This breaks ssh SSHFP
support for non-canonical hostnames. For example, "ssh zinc"
correctly discovers the FQDN (zinc.ee.lbl.gov) and uses it to
look up A and AAAA records but the non-canonical version (zinc)
is used in the SSHFP record lookup which or course fails.

Regenerate the patch.

Reviewed by: ? (mentor)
Approved by: bdrewery, ? (mentor)
Differential Revision: ?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 16120
Build 16075: arc lint + arc unit

Event Timeline

leres created this revision.Apr 12 2018, 8:33 PM
Herald added a subscriber: mat. · View Herald TranscriptApr 12 2018, 8:33 PM
Harbormaster completed remote builds in B16120: Diff 41415.Apr 12 2018, 8:33 PM
bdrewery added a comment.Apr 12 2018, 8:34 PM

Looks good but could you add the header back in from the des commit please? It lets me know I took it from the base patches. Anything above the --- ssh.c.orig line is ignored.

bdrewery requested changes to this revision.Apr 12 2018, 8:34 PM

Also you need to bump PORTREVISION too

This revision now requires changes to proceed.Apr 12 2018, 8:34 PM
leres updated this revision to Diff 41417.Apr 12 2018, 8:45 PM

Restore comment/header to patch-ssh.c and Bump PORTREVISION (oops).

Harbormaster completed remote builds in B16121: Diff 41417.Apr 12 2018, 8:45 PM
bdrewery accepted this revision.Apr 12 2018, 8:48 PM

Thank you!
Approved by me but I think you'll need mentor approval still.

This revision is now accepted and ready to land.Apr 12 2018, 8:48 PM
bdrewery added a comment.Apr 12 2018, 8:48 PM

Also "reviewed" by me.

ler accepted this revision.Apr 12 2018, 9:07 PM

LGTM

Closed by commit rP467200: The block of code that canonicallizes the hostname supplied on (authored by leres). · Explain WhyApr 12 2018, 9:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
security/
openssh-portable/
files/
23 lines

Diff 41415

View Options

security/openssh-portable/files/patch-ssh.c

Loading...