Page MenuHomeFreeBSD
Differential D15040

Add eventhandler for PCP network interface changes
ClosedPublic
Actions

Authored by • hselasky on Apr 11 2018, 9:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 1:59 AM
Unknown Object (File)
Mon, Mar 10, 8:50 PM
Unknown Object (File)
Sun, Mar 9, 11:20 AM
Unknown Object (File)
Sat, Mar 8, 4:04 AM
Unknown Object (File)
Feb 20 2025, 2:37 AM
Unknown Object (File)
Feb 18 2025, 9:09 PM
Unknown Object (File)
Feb 18 2025, 12:35 AM
Unknown Object (File)
Feb 17 2025, 4:20 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
ae
Commits
rS333101: MFC r333015:
rS333015: Add network device event for priority code point, PCP, changes.
Summary

Define an eventhandler to receive configuration changes related to the PCP value on a network interface. (WIP)

Further define a function prototype for this kind of events.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 16100

Event Timeline

• hselasky created this revision.Apr 11 2018, 9:47 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 11 2018, 9:47 AM
Harbormaster completed remote builds in B16097: Diff 41359.Apr 11 2018, 9:47 AM
• hselasky edited the summary of this revision. (Show Details)Apr 11 2018, 9:48 AM
• hselasky edited the summary of this revision. (Show Details)
• hselasky edited the summary of this revision. (Show Details)
• hselasky retitled this revision from Add event for PCP network interface changes to Add eventhandler for PCP network interface changes.Apr 11 2018, 9:53 AM
• hselasky edited the summary of this revision. (Show Details)
ae added a comment.Apr 11 2018, 9:54 AM

Maybe it would be enough to just introduce new IFNET_EVENT_PCP type for ifnet_event?

• hselasky added a comment.Apr 11 2018, 9:56 AM

That's also a possibility.

Any more comments?

--HPS

• hselasky updated this revision to Diff 41360.Apr 11 2018, 10:25 AM

Update patch according to suggestion from ae@

Harbormaster completed remote builds in B16098: Diff 41360.Apr 11 2018, 10:25 AM
ae accepted this revision.Apr 11 2018, 10:45 AM
This revision is now accepted and ready to land.Apr 11 2018, 10:45 AM
kib added a comment.Apr 11 2018, 11:00 AM

It is wrong, IMO, to not issue the PCP event on the same change for if_vlan.

kib added inline comments.Apr 11 2018, 11:01 AM
sys/net/if_ethersubr.c
1135 ↗(On Diff #41360)

The event should not be issued if the pcp is not set, i.e. it should be only called in the 'else' branch.

ae added inline comments.Apr 11 2018, 11:04 AM
sys/net/if_ethersubr.c
1135 ↗(On Diff #41360)

In this case we will not be notified when we want to reset PCP

ae added inline comments.Apr 11 2018, 11:05 AM
sys/net/if_ethersubr.c
1135 ↗(On Diff #41360)

Ah, I'm wrong.

• hselasky updated this revision to Diff 41364.Apr 11 2018, 11:58 AM
This revision now requires review to proceed.Apr 11 2018, 11:58 AM
Harbormaster completed remote builds in B16100: Diff 41364.Apr 11 2018, 11:58 AM
• hselasky added a comment.Apr 11 2018, 11:59 AM

What are the pros and cons of these alternatives?

--HPS

kib added a comment.Apr 11 2018, 12:17 PM
In D15040#316735, @hselasky wrote:

What are the pros and cons of these alternatives?

What alternatives ?

vlan-specific events are still not generated.

• hselasky updated this revision to Diff 41832.Apr 25 2018, 8:24 AM

Generate PCP event for both VLAN and LAN as suggested by @kib

Harbormaster completed remote builds in B16295: Diff 41832.Apr 25 2018, 8:24 AM
• hselasky added a comment.Apr 25 2018, 8:25 AM

Hi Guys, Can you have a fresh look at this patch again? I would like to complete this and possibly MFC to 11-stable.

kib accepted this revision.Apr 25 2018, 12:25 PM
This revision is now accepted and ready to land.Apr 25 2018, 12:25 PM
Closed by commit rS333015: Add network device event for priority code point, PCP, changes. (authored by • hselasky). · Explain WhyApr 26 2018, 8:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
net/
6 lines
2 lines

Diff 41364

View Options

net/if_ethersubr.c

Show All 38 Lines
#include <sys/stddef.h> #include <sys/stddef.h>
#include <sys/syslog.h> #include <sys/syslog.h>
#include <sys/time.h> #include <sys/time.h>
#include <linux/bitops.h> #include <linux/bitops.h>
#include <linux/build_bug.h> #include <linux/build_bug.h>
#include <linux/compiler.h> #include <linux/compiler.h>
#include <linux/container_of.h> #include <linux/container_of.h>
#include <linux/kstrtox.h>
#include <linux/limits.h> #include <linux/limits.h>
#include <linux/math.h> #include <linux/math.h>
#include <linux/minmax.h> #include <linux/minmax.h>
#include <linux/stringify.h> #include <linux/stringify.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/sched.h> #include <linux/sched.h>
#include <linux/types.h> #include <linux/types.h>
#include <linux/typecheck.h> #include <linux/typecheck.h>
▲ Show 20 Lines • Show All 208 Lines • ▼ Show 20 Lines
}) })
#endif #endif
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
#define u64_to_user_ptr(val) ((void *)(uintptr_t)(val)) #define u64_to_user_ptr(val) ((void *)(uintptr_t)(val))
#define _RET_IP_ __builtin_return_address(0) #define _RET_IP_ __builtin_return_address(0)
static inline unsigned long long
simple_strtoull(const char *cp, char **endp, unsigned int base)
{
return (strtouq(cp, endp, base));
}
static inline long long
simple_strtoll(const char *cp, char **endp, unsigned int base)
{
return (strtoq(cp, endp, base));
}
static inline unsigned long
simple_strtoul(const char *cp, char **endp, unsigned int base)
{
return (strtoul(cp, endp, base));
}
static inline long
simple_strtol(const char *cp, char **endp, unsigned int base)
{
return (strtol(cp, endp, base));
}
static inline int
kstrtoul(const char *cp, unsigned int base, unsigned long *res)
{
char *end;
*res = strtoul(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
return (0);
}
static inline int
kstrtol(const char *cp, unsigned int base, long *res)
{
char *end;
*res = strtol(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
return (0);
}
static inline int
kstrtoint(const char *cp, unsigned int base, int *res)
{
char *end;
long temp;
*res = temp = strtol(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
if (temp != (int)temp)
return (-ERANGE);
return (0);
}
static inline int
kstrtouint(const char *cp, unsigned int base, unsigned int *res)
{
char *end;
unsigned long temp;
*res = temp = strtoul(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
if (temp != (unsigned int)temp)
return (-ERANGE);
return (0);
}
static inline int
kstrtou8(const char *cp, unsigned int base, u8 *res)
{
char *end;
unsigned long temp;
*res = temp = strtoul(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
if (temp != (u8)temp)
return (-ERANGE);
return (0);
}
static inline int
kstrtou16(const char *cp, unsigned int base, u16 *res)
{
char *end;
unsigned long temp;
*res = temp = strtoul(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
if (temp != (u16)temp)
return (-ERANGE);
return (0);
}
static inline int
kstrtou32(const char *cp, unsigned int base, u32 *res)
{
return (kstrtouint(cp, base, res));
}
static inline int
kstrtou64(const char *cp, unsigned int base, u64 *res)
{
char *end;
*res = strtouq(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
return (0);
}
static inline int
kstrtoull(const char *cp, unsigned int base, unsigned long long *res)
{
return (kstrtou64(cp, base, (u64 *)res));
}
static inline int
kstrtobool(const char *s, bool *res)
{
int len;
if (s == NULL || (len = strlen(s)) == 0 || res == NULL)
return (-EINVAL);
/* skip newline character, if any */
if (s[len - 1] == '\n')
len--;
if (len == 1 && strchr("yY1", s[0]) != NULL)
*res = true;
else if (len == 1 && strchr("nN0", s[0]) != NULL)
*res = false;
else if (strncasecmp("on", s, len) == 0)
*res = true;
else if (strncasecmp("off", s, len) == 0)
*res = false;
else
return (-EINVAL);
return (0);
}
static inline int
kstrtobool_from_user(const char __user *s, size_t count, bool *res)
{
char buf[8] = {};
if (count > (sizeof(buf) - 1))
count = (sizeof(buf) - 1);
if (copy_from_user(buf, s, count))
return (-EFAULT);
return (kstrtobool(buf, res));
}
static inline int
kstrtoint_from_user(const char __user *s, size_t count, unsigned int base,
int *p)
{
char buf[36] = {};
if (count > (sizeof(buf) - 1))
count = (sizeof(buf) - 1);
if (copy_from_user(buf, s, count))
return (-EFAULT);
return (kstrtoint(buf, base, p));
}
static inline int
kstrtouint_from_user(const char __user *s, size_t count, unsigned int base,
unsigned int *p)
{
char buf[36] = {};
if (count > (sizeof(buf) - 1))
count = (sizeof(buf) - 1);
if (copy_from_user(buf, s, count))
return (-EFAULT);
return (kstrtouint(buf, base, p));
}
static inline int
kstrtou32_from_user(const char __user *s, size_t count, unsigned int base,
unsigned int *p)
{
return (kstrtouint_from_user(s, count, base, p));
}
static inline int
kstrtou8_from_user(const char __user *s, size_t count, unsigned int base,
u8 *p)
{
char buf[8] = {};
if (count > (sizeof(buf) - 1))
count = (sizeof(buf) - 1);
if (copy_from_user(buf, s, count))
return (-EFAULT);
return (kstrtou8(buf, base, p));
}
#define offsetofend(t, m) \ #define offsetofend(t, m) \
(offsetof(t, m) + sizeof((((t *)0)->m))) (offsetof(t, m) + sizeof((((t *)0)->m)))
#define smp_processor_id() PCPU_GET(cpuid) #define smp_processor_id() PCPU_GET(cpuid)
#define num_possible_cpus() mp_ncpus #define num_possible_cpus() mp_ncpus
#define num_online_cpus() mp_ncpus #define num_online_cpus() mp_ncpus
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines
View Options

net/if_var.h

Show All 38 Lines
#include <sys/stddef.h> #include <sys/stddef.h>
#include <sys/syslog.h> #include <sys/syslog.h>
#include <sys/time.h> #include <sys/time.h>
#include <linux/bitops.h> #include <linux/bitops.h>
#include <linux/build_bug.h> #include <linux/build_bug.h>
#include <linux/compiler.h> #include <linux/compiler.h>
#include <linux/container_of.h> #include <linux/container_of.h>
#include <linux/kstrtox.h>
#include <linux/limits.h> #include <linux/limits.h>
#include <linux/math.h> #include <linux/math.h>
#include <linux/minmax.h> #include <linux/minmax.h>
#include <linux/stringify.h> #include <linux/stringify.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/sched.h> #include <linux/sched.h>
#include <linux/types.h> #include <linux/types.h>
#include <linux/typecheck.h> #include <linux/typecheck.h>
▲ Show 20 Lines • Show All 208 Lines • ▼ Show 20 Lines
}) })
#endif #endif
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
#define u64_to_user_ptr(val) ((void *)(uintptr_t)(val)) #define u64_to_user_ptr(val) ((void *)(uintptr_t)(val))
#define _RET_IP_ __builtin_return_address(0) #define _RET_IP_ __builtin_return_address(0)
static inline unsigned long long
simple_strtoull(const char *cp, char **endp, unsigned int base)
{
return (strtouq(cp, endp, base));
}
static inline long long
simple_strtoll(const char *cp, char **endp, unsigned int base)
{
return (strtoq(cp, endp, base));
}
static inline unsigned long
simple_strtoul(const char *cp, char **endp, unsigned int base)
{
return (strtoul(cp, endp, base));
}
static inline long
simple_strtol(const char *cp, char **endp, unsigned int base)
{
return (strtol(cp, endp, base));
}
static inline int
kstrtoul(const char *cp, unsigned int base, unsigned long *res)
{
char *end;
*res = strtoul(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
return (0);
}
static inline int
kstrtol(const char *cp, unsigned int base, long *res)
{
char *end;
*res = strtol(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
return (0);
}
static inline int
kstrtoint(const char *cp, unsigned int base, int *res)
{
char *end;
long temp;
*res = temp = strtol(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
if (temp != (int)temp)
return (-ERANGE);
return (0);
}
static inline int
kstrtouint(const char *cp, unsigned int base, unsigned int *res)
{
char *end;
unsigned long temp;
*res = temp = strtoul(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
if (temp != (unsigned int)temp)
return (-ERANGE);
return (0);
}
static inline int
kstrtou8(const char *cp, unsigned int base, u8 *res)
{
char *end;
unsigned long temp;
*res = temp = strtoul(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
if (temp != (u8)temp)
return (-ERANGE);
return (0);
}
static inline int
kstrtou16(const char *cp, unsigned int base, u16 *res)
{
char *end;
unsigned long temp;
*res = temp = strtoul(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
if (temp != (u16)temp)
return (-ERANGE);
return (0);
}
static inline int
kstrtou32(const char *cp, unsigned int base, u32 *res)
{
return (kstrtouint(cp, base, res));
}
static inline int
kstrtou64(const char *cp, unsigned int base, u64 *res)
{
char *end;
*res = strtouq(cp, &end, base);
/* skip newline character, if any */
if (*end == '\n')
end++;
if (*cp == 0 || *end != 0)
return (-EINVAL);
return (0);
}
static inline int
kstrtoull(const char *cp, unsigned int base, unsigned long long *res)
{
return (kstrtou64(cp, base, (u64 *)res));
}
static inline int
kstrtobool(const char *s, bool *res)
{
int len;
if (s == NULL || (len = strlen(s)) == 0 || res == NULL)
return (-EINVAL);
/* skip newline character, if any */
if (s[len - 1] == '\n')
len--;
if (len == 1 && strchr("yY1", s[0]) != NULL)
*res = true;
else if (len == 1 && strchr("nN0", s[0]) != NULL)
*res = false;
else if (strncasecmp("on", s, len) == 0)
*res = true;
else if (strncasecmp("off", s, len) == 0)
*res = false;
else
return (-EINVAL);
return (0);
}
static inline int
kstrtobool_from_user(const char __user *s, size_t count, bool *res)
{
char buf[8] = {};
if (count > (sizeof(buf) - 1))
count = (sizeof(buf) - 1);
if (copy_from_user(buf, s, count))
return (-EFAULT);
return (kstrtobool(buf, res));
}
static inline int
kstrtoint_from_user(const char __user *s, size_t count, unsigned int base,
int *p)
{
char buf[36] = {};
if (count > (sizeof(buf) - 1))
count = (sizeof(buf) - 1);
if (copy_from_user(buf, s, count))
return (-EFAULT);
return (kstrtoint(buf, base, p));
}
static inline int
kstrtouint_from_user(const char __user *s, size_t count, unsigned int base,
unsigned int *p)
{
char buf[36] = {};
if (count > (sizeof(buf) - 1))
count = (sizeof(buf) - 1);
if (copy_from_user(buf, s, count))
return (-EFAULT);
return (kstrtouint(buf, base, p));
}
static inline int
kstrtou32_from_user(const char __user *s, size_t count, unsigned int base,
unsigned int *p)
{
return (kstrtouint_from_user(s, count, base, p));
}
static inline int
kstrtou8_from_user(const char __user *s, size_t count, unsigned int base,
u8 *p)
{
char buf[8] = {};
if (count > (sizeof(buf) - 1))
count = (sizeof(buf) - 1);
if (copy_from_user(buf, s, count))
return (-EFAULT);
return (kstrtou8(buf, base, p));
}
#define offsetofend(t, m) \ #define offsetofend(t, m) \
(offsetof(t, m) + sizeof((((t *)0)->m))) (offsetof(t, m) + sizeof((((t *)0)->m)))
#define smp_processor_id() PCPU_GET(cpuid) #define smp_processor_id() PCPU_GET(cpuid)
#define num_possible_cpus() mp_ncpus #define num_possible_cpus() mp_ncpus
#define num_online_cpus() mp_ncpus #define num_online_cpus() mp_ncpus
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines