Page MenuHomeFreeBSD
Differential D15040

Add eventhandler for PCP network interface changes
ClosedPublic
Actions

Authored by • hselasky on Apr 11 2018, 9:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 1, 10:45 AM
Unknown Object (File)
Sun, Sep 27, 4:33 PM
Unknown Object (File)
Sun, Sep 27, 4:16 PM
Unknown Object (File)
Sun, Sep 27, 4:12 PM
Unknown Object (File)
Sun, Sep 27, 4:11 PM
Unknown Object (File)
Sun, Sep 27, 3:56 PM
Unknown Object (File)
Sun, Sep 27, 5:24 AM
Unknown Object (File)
Thu, Sep 10, 8:48 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
ae
Commits
rS333101: MFC r333015:
rS333015: Add network device event for priority code point, PCP, changes.
Summary

Define an eventhandler to receive configuration changes related to the PCP value on a network interface. (WIP)

Further define a function prototype for this kind of events.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• hselasky created this revision.Apr 11 2018, 9:47 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 11 2018, 9:47 AM
Harbormaster completed remote builds in B16097: Diff 41359.Apr 11 2018, 9:47 AM
• hselasky edited the summary of this revision. (Show Details)Apr 11 2018, 9:48 AM
• hselasky edited the summary of this revision. (Show Details)
• hselasky edited the summary of this revision. (Show Details)
• hselasky retitled this revision from Add event for PCP network interface changes to Add eventhandler for PCP network interface changes.Apr 11 2018, 9:53 AM
• hselasky edited the summary of this revision. (Show Details)
ae added a comment.Apr 11 2018, 9:54 AM

Maybe it would be enough to just introduce new IFNET_EVENT_PCP type for ifnet_event?

• hselasky added a comment.Apr 11 2018, 9:56 AM

That's also a possibility.

Any more comments?

--HPS

• hselasky updated this revision to Diff 41360.Apr 11 2018, 10:25 AM

Update patch according to suggestion from ae@

Harbormaster completed remote builds in B16098: Diff 41360.Apr 11 2018, 10:25 AM
ae accepted this revision.Apr 11 2018, 10:45 AM
This revision is now accepted and ready to land.Apr 11 2018, 10:45 AM
kib added a comment.Apr 11 2018, 11:00 AM

It is wrong, IMO, to not issue the PCP event on the same change for if_vlan.

kib added inline comments.Apr 11 2018, 11:01 AM
sys/net/if_ethersubr.c
1135 ↗(On Diff #41360)

The event should not be issued if the pcp is not set, i.e. it should be only called in the 'else' branch.

ae added inline comments.Apr 11 2018, 11:04 AM
sys/net/if_ethersubr.c
1135 ↗(On Diff #41360)

In this case we will not be notified when we want to reset PCP

ae added inline comments.Apr 11 2018, 11:05 AM
sys/net/if_ethersubr.c
1135 ↗(On Diff #41360)

Ah, I'm wrong.

• hselasky updated this revision to Diff 41364.Apr 11 2018, 11:58 AM
This revision now requires review to proceed.Apr 11 2018, 11:58 AM
Harbormaster completed remote builds in B16100: Diff 41364.Apr 11 2018, 11:58 AM
• hselasky added a comment.Apr 11 2018, 11:59 AM

What are the pros and cons of these alternatives?

--HPS

kib added a comment.Apr 11 2018, 12:17 PM
In D15040#316735, @hselasky wrote:

What are the pros and cons of these alternatives?

What alternatives ?

vlan-specific events are still not generated.

• hselasky updated this revision to Diff 41832.Apr 25 2018, 8:24 AM

Generate PCP event for both VLAN and LAN as suggested by @kib

Harbormaster completed remote builds in B16295: Diff 41832.Apr 25 2018, 8:24 AM
• hselasky added a comment.Apr 25 2018, 8:25 AM

Hi Guys, Can you have a fresh look at this patch again? I would like to complete this and possibly MFC to 11-stable.

kib accepted this revision.Apr 25 2018, 12:25 PM
This revision is now accepted and ready to land.Apr 25 2018, 12:25 PM
Closed by commit rS333015: Add network device event for priority code point, PCP, changes. (authored by • hselasky). · Explain WhyApr 26 2018, 8:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
net/
7 lines
2 lines
2 lines

Diff 41879

View Options

head/sys/net/if_ethersubr.c

Loading...
View Options

head/sys/net/if_var.h

Loading...
View Options

head/sys/net/if_vlan.c

Loading...