Page MenuHomeFreeBSD
Differential D14104

Implement pinctl functionality for Raspberr Pi platform
ClosedPublic
Actions

Authored by gonzo on Jan 29 2018, 2:59 AM.
Tags
None
Referenced Files
F105968608: D14104.id38645.diff
Mon, Dec 23, 6:17 AM
Unknown Object (File)
Fri, Dec 20, 6:57 PM
Unknown Object (File)
Thu, Nov 28, 9:26 PM
Unknown Object (File)
Tue, Nov 26, 1:15 PM
Unknown Object (File)
Nov 1 2024, 4:05 PM
Unknown Object (File)
Oct 26 2024, 1:07 AM
Unknown Object (File)
Oct 25 2024, 4:56 PM
Unknown Object (File)
Oct 5 2024, 7:09 AM
View All 74 Files
Subscribers
andrew
imp
loos

Details

Reviewers
manu
imp
Commits
rS332262: [rpi] Add fdt_pinctrl(4) support to Raspberry Pi GPIO driver
Summary

On Raspberry Pi platform GPIO controller also responsible for pins
multiplexing. Pi code predates proper FDT support in FreeBSD so a
lot of pinmux info is hardcoded. This patch:

  • Implements pinctl methods in bcm2835_gpio
  • Converts all devices with ad-hoc pinmux info to proper pin control mechanisms and adds pinmux info in FreeBSD's custom dts files.
  • Add fdt_pinctl option to RPI2 kernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gonzo created this revision.Jan 29 2018, 2:59 AM
Herald added a reviewer: manu. · View Herald TranscriptJan 29 2018, 2:59 AM
Herald added subscribers: loos, andrew, imp. · View Herald Transcript
Harbormaster completed remote builds in B14638: Diff 38598.Jan 29 2018, 2:59 AM
manu added a comment.Jan 29 2018, 7:29 AM

At first glance this looks ok, I'll review more and test on different RPI tonight.
Thank you for working on this.

gonzo updated this revision to Diff 38645.Jan 29 2018, 8:17 PM

Do not include GPL bindings header

Harbormaster completed remote builds in B14662: Diff 38645.Jan 29 2018, 8:17 PM
manu added a comment.Jan 29 2018, 8:45 PM

Just this comment but otherwise it looks good.
Thanks for working on this

Tested-On: RPI-B
Tested-On: RPI-0 v1.2

sys/arm/broadcom/bcm2835/bcm2835_gpio.c
1234 ↗(On Diff #38645)

It misses an OF_prop_free(pins) here

andrew added inline comments.Jan 30 2018, 11:43 AM
sys/arm/broadcom/bcm2835/std.rpi
4 ↗(On Diff #38645)

This should be in the relevant kernel config files

gonzo updated this revision to Diff 38750.Feb 1 2018, 6:04 AM
  • Fix memory leak
  • Move fdt_pinctrl to relevant config files
Harbormaster completed remote builds in B14722: Diff 38750.Feb 1 2018, 6:04 AM
manu accepted this revision.Feb 1 2018, 11:17 AM
This revision is now accepted and ready to land.Feb 1 2018, 11:17 AM
imp accepted this revision.Feb 1 2018, 3:38 PM
imp added inline comments.
sys/arm/conf/RPI-B
93 ↗(On Diff #38750)

So this isn't in GENERIC? Why not?

andrew added inline comments.Feb 1 2018, 4:16 PM
sys/arm/conf/RPI-B
93 ↗(On Diff #38750)

It's already in GENERIC on armv7 and arm64

imp added a comment.Feb 1 2018, 4:21 PM

I see no further issues

sys/arm/conf/RPI-B
93 ↗(On Diff #38750)

That's what I get for grepping for fdt_pinmux :)

gonzo added a child revision: D14168: BCM2835 (Raspberry Pi 3) sdhost device driver.Feb 8 2018, 8:03 PM
gonzo mentioned this in D14168: BCM2835 (Raspberry Pi 3) sdhost device driver.Feb 21 2018, 10:46 PM
Closed by commit rS332262: [rpi] Add fdt_pinctrl(4) support to Raspberry Pi GPIO driver (authored by gonzo). · Explain WhyApr 8 2018, 12:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
broadcom/
bcm2835/
30 lines
10 lines
46 lines
149 lines
2 lines
10 lines
13 lines
12 lines
2 lines
conf/
2 lines
2 lines
dts/
arm/
15 lines
12 lines

Diff 41245

View Options

head/sys/arm/broadcom/bcm2835/bcm2835_bsc.c

Loading...
View Options

head/sys/arm/broadcom/bcm2835/bcm2835_bscvar.h

Loading...
View Options

head/sys/arm/broadcom/bcm2835/bcm2835_gpio.h

Loading...
View Options

head/sys/arm/broadcom/bcm2835/bcm2835_gpio.c

Loading...
View Options

head/sys/arm/broadcom/bcm2835/bcm2835_intr.c

Loading...
View Options

head/sys/arm/broadcom/bcm2835/bcm2835_pwm.c

Loading...
View Options

head/sys/arm/broadcom/bcm2835/bcm2835_spi.c

Loading...
View Options

head/sys/arm/broadcom/bcm2835/bcm2835_spivar.h

Loading...
View Options

head/sys/arm/broadcom/bcm2835/bcm2836.c

Loading...
View Options

head/sys/arm/conf/RPI-B

Loading...
View Options

head/sys/arm/conf/RPI2

Loading...
View Options

head/sys/dts/arm/rpi.dts

Loading...
View Options

head/sys/dts/arm/rpi2.dts

Loading...