Check that in_pcbfree() is only called once for each PCB.
ClosedPublic
Actions

Authored by jtl on Apr 6 2018, 4:31 PM.

Tags

None

Referenced Files

	F115177323: D14990.id41187.diff
	Mon, Apr 21, 4:17 AM

	Unknown Object (File)
	Mon, Apr 14, 11:17 AM

	Unknown Object (File)
	Mon, Apr 14, 5:19 AM

	Unknown Object (File)
	Mon, Apr 14, 1:05 AM

	Unknown Object (File)
	Mon, Apr 14, 12:27 AM

	Unknown Object (File)
	Wed, Apr 9, 11:08 AM

	Unknown Object (File)
	Wed, Apr 9, 4:15 AM

	Unknown Object (File)
	Wed, Apr 9, 4:13 AM

View All 53 Files

Subscribers

imp

jch

Details

Reviewers

rrs

Commits

rS332114: Check that in_pcbfree() is only called once for each PCB. If that

Summary

Check that in_pcbfree() is only called once for each PCB. If that assumption is violated, "bad things" could follow.

I believe such an assert would have detected some of the problems @jch was chasing in PR 203175 (see r307551). We also use it in our internal TCP development.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtl created this revision.Apr 6 2018, 4:31 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 6 2018, 4:31 PM

Harbormaster completed remote builds in B16020: Diff 41187.Apr 6 2018, 4:31 PM

rrs accepted this revision.Apr 6 2018, 4:36 PM

This revision is now accepted and ready to land.Apr 6 2018, 4:36 PM

Closed by commit rS332114: Check that in_pcbfree() is only called once for each PCB. If that (authored by jtl). · Explain WhyApr 6 2018, 4:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

in_pcb.c

7 lines

Diff 41188

View Options

Check that in_pcbfree() is only called once for each PCB.ClosedPublicActions