Check that in_pcbfree() is only called once for each PCB.
ClosedPublic
Actions

Authored by jtl on Apr 6 2018, 4:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 25, 6:16 AM

	Unknown Object (File)
	Nov 25 2024, 10:40 AM

	Unknown Object (File)
	Nov 14 2024, 3:50 PM

	Unknown Object (File)
	Oct 24 2024, 11:10 PM

	Unknown Object (File)
	Sep 25 2024, 11:58 PM

	Unknown Object (File)
	Sep 25 2024, 3:12 PM

	Unknown Object (File)
	Sep 24 2024, 11:23 PM

	Unknown Object (File)
	Sep 24 2024, 8:16 AM

View All 42 Files

Subscribers

imp

jch

Details

Reviewers

rrs

Commits

rS332114: Check that in_pcbfree() is only called once for each PCB. If that

Summary

Check that in_pcbfree() is only called once for each PCB. If that assumption is violated, "bad things" could follow.

I believe such an assert would have detected some of the problems @jch was chasing in PR 203175 (see r307551). We also use it in our internal TCP development.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16020
Build 15999: arc lint + arc unit

Event Timeline

jtl created this revision.Apr 6 2018, 4:31 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 6 2018, 4:31 PM

Harbormaster completed remote builds in B16020: Diff 41187.Apr 6 2018, 4:31 PM

rrs accepted this revision.Apr 6 2018, 4:36 PM

This revision is now accepted and ready to land.Apr 6 2018, 4:36 PM

Closed by commit rS332114: Check that in_pcbfree() is only called once for each PCB. If that (authored by jtl). · Explain WhyApr 6 2018, 4:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

7 lines

Diff 41187

View Options

Check that in_pcbfree() is only called once for each PCB.ClosedPublicActions