Page MenuHomeFreeBSD

New port www/gitlab-pages required for gitlab 10.5.x update
ClosedPublic

Authored by mfechner on Mar 25 2018, 7:10 AM.
Tags
None
Referenced Files
F81622967: D14841.diff
Fri, Apr 19, 3:33 AM
Unknown Object (File)
Wed, Apr 10, 11:13 AM
Unknown Object (File)
Mon, Apr 8, 7:41 PM
Unknown Object (File)
Mon, Apr 8, 7:40 PM
Unknown Object (File)
Mon, Apr 8, 4:39 AM
Unknown Object (File)
Mar 7 2024, 2:50 AM
Unknown Object (File)
Feb 1 2024, 5:19 PM
Unknown Object (File)
Feb 1 2024, 5:19 PM
Subscribers

Details

Summary

Commit message will be:
New ports required for gitlab update to 10.5.x.

Submitted by: swills@freebsd.org
Reviewed by: tz/swills (mentor)
Approved by: tz/swills (mentor)
Differential Revision: URL to this revision

Test Plan

All patches are build, you can find all build logs:
https://pkg.fechner.net/jail.html?mastername=111amd64-gitlab

The fresh packages are tested against a new installation using:
https://gitlab.fechner.net/mfechner/Gitlab-vagrant

An old version is updated following the manual:
https://gitlab.fechner.net/mfechner/Gitlab-docu

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

www/gitlab-pages/Makefile
7–8

Please use USE_GITLAB.

41–45

Do all this in one target.

www/gitlab-pages/Makefile
7–8

FWIW, when this was initially created, USE_GITHUB didn't exist.

41–45

I don't understand why the rm is needed.

www/gitlab-pages/Makefile
7–8

Thanks for this tip, I will check the documentation.

41–45

The rm is needed because go creates with the new version a cache and poudriere will then complain about a dirty directory and stops creating the package.

I'm not sure if it is an issue which should be handled in poudriere by setting the newly required env variables.
Maybe this problem is already fixed. The time I tested the port it was required to build it.

I will look again into this issue after the gitlab update is in ports. gitlab-pages is not that important yet, we can bring it also later.

www/gitlab-pages/Makefile
41–45

Setting the GOCACHE=off environment variable during the build will disable the cache.

Updated diff to not use cache for go and removed the rm command.

This revision is now accepted and ready to land.Apr 6 2018, 3:18 PM
This revision was automatically updated to reflect the committed changes.