Page MenuHomeFreeBSD
Differential D687

vt(4): Add support to "downgrade" from eg. vt_fb to vt_vga
ClosedPublic
Actions

Authored by dumbbell on Aug 26 2014, 10:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 12:03 PM
Unknown Object (File)
Nov 19 2024, 6:50 PM
Unknown Object (File)
Nov 17 2024, 7:28 AM
Unknown Object (File)
Nov 14 2024, 11:26 PM
Unknown Object (File)
Nov 11 2024, 5:17 AM
Unknown Object (File)
Oct 31 2024, 2:37 PM
Unknown Object (File)
Oct 28 2024, 6:50 AM
Unknown Object (File)
Oct 27 2024, 2:37 AM
View All Files
Subscribers
• hselasky
jhb

Details

Reviewers
ray
emaste
jhb
Commits
rS279488: vt(4): Add support to "downgrade" from eg. vt_fb to vt_vga
rS279487: vgapci: New vga_pci_repost() function
Summary

The main purpose is to be able to unload a KMS driver. It's at least useful to me while working on the DRM stack, because it saves me a reboot :)

The patch introduces a new vt_driver callback, vd_reset_t, which is called after the old driver is stopped (old = fbd) and before the new driver is initialized (new = vt_vga). The callback is really implemented in drm_fb_helper.c where vga_pci_repost() is called (a new public function in vga_pci) to restore the VGA state.

Currently, the DRM code in HEAD seems to turn off the screen during shutdown, and re-POSTing the card isn't enough to turn it back on. The problem doesn't occur with my DRM 3.8 development branch (the console comes back with vt_vga and everything works).

Test Plan

kldload radeonkms
kldunload radeonkms

The console should still work

This can't be tested with i915kms which doesn't support unloading.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

dumbbell updated this revision to Diff 1259.Aug 26 2014, 10:33 AM
dumbbell retitled this revision from to vt(4): Add support to "downgrade" from eg. vt_fb to vt_vga.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: emaste, ray.
emaste edited edge metadata.Nov 10 2014, 3:35 PM
emaste added a subscriber: jhb.

Adding jhb as a subscriber to look at vga_pci.c

sys/dev/drm2/radeon/radeon_fb.c
294

Why do we need vga_pci_repost both here and in vt_kms_reset?

dumbbell added inline comments.Nov 10 2014, 3:48 PM
sys/dev/drm2/radeon/radeon_fb.c
294

This is a mistake I don't have locally anymore. I still haven't published a revised patch (which is not finished anyway).

However, I only changed what calls what to address concerns expressed outside of Phabricator. The vga_pci_repost() function is unchanged and it needs review, because I'm not sure of what I do :)

emaste added a comment.Dec 15 2014, 7:31 PM

What's next here?

dumbbell added a comment.Dec 16 2014, 9:07 AM

I need to publish a newer version of the patch, but didn't have the time to do it so far. Once xserver 1.14 is committed, I will work on a few vt(4) changes, like D1004 and this one.

dumbbell updated this revision to Diff 3163.Jan 13 2015, 11:40 PM
dumbbell edited edge metadata.

Each part should be properly isolated now. Only vt_vga nows about repost.

dumbbell added inline comments.Jan 13 2015, 11:44 PM
sys/dev/drm2/radeon/radeon_fb.c
295

Note that the device_delete_child() is moved to a central function in drm_fb_helper.c in my DRM update branch. This avoids to do it in each driver. This function is missing in our current DRM and I didn't want to import new code for now.

jhb added inline comments.Jan 14 2015, 2:00 PM
sys/dev/vt/vt.h
128

I would perhaps call these 'vd_prev_*' instead of 'vd_old_*'

dumbbell updated this revision to Diff 3176.Jan 14 2015, 9:52 PM

Rename vd_old_* to vd_prev_*

dumbbell added a reviewer: jhb.Feb 7 2015, 4:24 PM

Do you have any comment on this?

I'd like to commit it to HEAD to ease the work on i915.

• hselasky added a subscriber: • hselasky.Feb 23 2015, 10:29 PM

Hi,

I need this for dev/usb/video/udl.c which unloads when the device detaches. Can you please commit it?

--HPS

dumbbell updated this revision to Diff 4047.Mar 1 2015, 11:40 AM

Regenerated the patch after some changes in vt(4)

If there is no objection, I'm going to commit this patch as I need it to
work on DRM.

dumbbell closed this revision.Mar 1 2015, 12:48 PM
dumbbell updated this revision to Diff 4048.

Closed by commit rS279487 (authored by @dumbbell).

Revision Contents
Changeset List

PathSize
sys/
dev/
drm2/
12 lines
radeon/
2 lines
fb/
2 lines
pci/
1 line
32 lines
vt/
hw/
fb/
2 lines
18 lines
vga/
4 lines
9 lines
113 lines
sys/
3 lines

Diff 4047

View Options

sys/dev/drm2/drm_fb_helper.c

Loading...
View Options

sys/dev/drm2/radeon/radeon_fb.c

Loading...
View Options

sys/dev/fb/fbd.c

Loading...
View Options

sys/dev/pci/pcivar.h

Loading...
View Options

sys/dev/pci/vga_pci.c

Loading...
View Options

sys/dev/vt/hw/fb/vt_fb.h

Loading...
View Options

sys/dev/vt/hw/fb/vt_fb.c

Loading...
View Options

sys/dev/vt/hw/vga/vt_vga.c

Loading...
View Options

sys/dev/vt/vt.h

Loading...
View Options

sys/dev/vt/vt_core.c

Loading...
View Options

sys/sys/fbio.h

Loading...