Convert bpf(9) counters to counter(9).
ClosedPublic
Actions

Authored by melifaro on Mar 17 2018, 11:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 11, 6:40 PM

	Unknown Object (File)
	Sun, May 10, 10:06 PM

	Unknown Object (File)
	Sun, May 10, 5:00 PM

	Unknown Object (File)
	Thu, May 7, 11:45 AM

	Unknown Object (File)
	Fri, Apr 24, 12:12 PM

	Unknown Object (File)
	Wed, Apr 15, 11:56 PM

	Unknown Object (File)
	Apr 14 2026, 11:40 AM

	Unknown Object (File)
	Apr 13 2026, 1:58 AM

View All Files

Subscribers

imp

Details

Reviewers

ae
kp

Group Reviewers

network

Commits

rS331275: Use count(9) api for the bpf(4) statistics.

Summary

Currently each bfp descriptor uses u64 variables to maintain its counters.
On interfaces with high packet rate this leads to unnecessary contention and
inaccurate reporting. Fix this by using standard counter(9) API for each counter.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15625
Build 15661: arc lint + arc unit

Event Timeline

melifaro created this revision.Mar 17 2018, 11:35 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 17 2018, 11:35 PM

Harbormaster completed remote builds in B15625: Diff 40395.Mar 17 2018, 11:35 PM

Looks sane to me.

This revision is now accepted and ready to land.Mar 18 2018, 11:23 AM

Closed by commit rS331275: Use count(9) api for the bpf(4) statistics. (authored by melifaro). · Explain WhyMar 20 2018, 10:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

net/

bpf.c

95 lines

bpfdesc.h

15 lines

Diff 40395

View Options

sys/net/bpf.c