Move implementation of ioctls into kern_*() functions.
ClosedPublic
Actions

Authored by brooks on Mar 14 2018, 11:59 PM.

Details

Reviewers

kib
cem
markj

Commits

rS331014: Move implementation of ioctls into kern_*() functions.

Summary

Move locks from outside ioctl to the individual implementations.

This is the first step of changing the implementations to act on a
kernel-internal request struct rather than on struct md_ioctl and to
removing the use of kern_ioctl in mountroot.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15583
Build 15619: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 14 2018, 11:59 PM

Harbormaster completed remote builds in B15572: Diff 40305.Mar 14 2018, 11:59 PM

cem accepted this revision.Mar 15 2018, 12:34 AM

cem added inline comments.

sys/dev/md/md.c
1776–1777	else break? Doesn't seem to be any point in continuing the loop once the output buffer is full. That can wait for a separate commit though.

This revision is now accepted and ready to land.Mar 15 2018, 12:34 AM

With this structure, I would expect the lock to be pushed into individual ioctl routines, in fact.

sys/dev/md/md.c
1747	Perhaps use the opportunity and return EFAULT if this copyout failed ?

markj accepted this revision.Mar 15 2018, 1:43 PM

I'll update following @kib's suggestions shortly.

sys/dev/md/md.c
1776–1777	The continued looping is to finish counting which is the ABI (both a count and a terminator, historically the terminator only existed if the set didn't fit). The ABI is broken by design and prior to r330880 the loop was a kernel buffer overflow.

cem added inline comments.Mar 15 2018, 4:18 PM

sys/dev/md/md.c
1776–1777	If that's what it's for, it's broken now. We won't ever increment `i` again. Probably need `else i++;` or similar.

brooks marked an inline comment as done.Mar 15 2018, 4:38 PM

brooks added inline comments.

sys/dev/md/md.c
1776–1777	Oops, fixed in HEAD, will fix here.

Rebase
Return immediatly if copyout of md_label fails.
Move locking into command implementations.
Unconditionally increment count to preserve ABI.

This revision now requires review to proceed.Mar 15 2018, 4:49 PM

Harbormaster completed remote builds in B15583: Diff 40321.Mar 15 2018, 4:49 PM

brooks marked 4 inline comments as done.Mar 15 2018, 4:50 PM

cem accepted this revision.Mar 15 2018, 4:56 PM

This revision is now accepted and ready to land.Mar 15 2018, 4:56 PM

brooks retitled this revision from Move implementation of ioctls into kern_*_locked() functions. to Move implementation of ioctls into kern_*() functions..Mar 15 2018, 5:00 PM

brooks edited the summary of this revision. (Show Details)

kib accepted this revision.Mar 15 2018, 5:14 PM

Closed by commit rS331014: Move implementation of ioctls into kern_*() functions. (authored by brooks). · Explain WhyMar 15 2018, 6:13 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMar 15 2018, 6:13 PM