Page MenuHomeFreeBSD
Differential D14660

deskutils/znotes: Add Qt5 OPTION and support
ClosedPublic
Actions

Authored by rigoletto on Mar 11 2018, 9:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 20, 7:16 AM
Unknown Object (File)
Nov 29 2024, 9:10 PM
Unknown Object (File)
Nov 8 2024, 3:47 AM
Unknown Object (File)
Oct 25 2024, 3:31 AM
Unknown Object (File)
Oct 19 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 9:07 PM
Unknown Object (File)
Oct 13 2024, 12:02 PM
Unknown Object (File)
Oct 8 2024, 9:56 PM
View All 99 Files
Subscribers
mat
Contributor Reviewers (ports)

Details

Reviewers
tcberner
adridg
mat
Commits
rP468608: Flavorize deskutils/znotes
Summary
  • adopt it
  • add Qt5 support

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 15505
Build 15546: arc lint + arc unit

Event Timeline

rigoletto created this revision.Mar 11 2018, 9:47 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptMar 11 2018, 9:47 PM
Harbormaster completed remote builds in B15505: Diff 40182.Mar 11 2018, 9:47 PM
rigoletto added reviewers: tcberner, adridg.Mar 11 2018, 9:48 PM
tcberner added inline comments.Mar 12 2018, 5:54 AM
deskutils/znotes/Makefile
25

how about flavors?

tcberner added inline comments.Mar 12 2018, 6:18 AM
deskutils/znotes/Makefile
5

instead of bumping you should maybe change the version number to the something like
0.4.5.20150825

29

^ is this really needed? It should find LRELEASE on its own.

tcberner added inline comments.Mar 12 2018, 6:22 AM
deskutils/znotes/Makefile
5

See:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex2

tcberner added inline comments.Mar 12 2018, 7:06 AM
deskutils/znotes/Makefile
35

^ propbably you want either to get rid of the NLS option, or move the linguist* deps to NLS_USE=QT[45]=...

mat added inline comments.Mar 12 2018, 10:23 AM
deskutils/znotes/Makefile
5

it's not a question of "should maybe change" it is a question of must. The upstream version is not the same, so the port version must be updated.

25

Yes, please.

rigoletto updated this revision to Diff 40217.Mar 12 2018, 8:10 PM
rigoletto marked 7 inline comments as done.

Done. :-)

Harbormaster completed remote builds in B15523: Diff 40217.Mar 12 2018, 8:10 PM
rigoletto added a comment.Mar 13 2018, 1:16 AM

Should I set Qt5 as default FLAVOR?

Thanks!

mat added a comment.Mar 13 2018, 10:50 AM

This looks good. We currently do not accept flavors that add new packages though, so this change will be able to go in when ports-mgmt/poudriere is updated to 3.3.

rigoletto updated this revision to Diff 40275.Mar 14 2018, 4:55 AM

Updating new maintainer (me) e-mail address.

Thanks! :-D

Harbormaster completed remote builds in B15558: Diff 40275.Mar 14 2018, 4:55 AM
tcberner added a comment.Mar 14 2018, 5:56 AM

I guess I will commit this after poudriere 3.3 has landed then, ok?

rigoletto added a comment.Mar 14 2018, 5:01 PM
In D14660#308589, @tcberner wrote:

I guess I will commit this after poudriere 3.3 has landed then, ok?

Fine. 😄

mat accepted this revision.Apr 18 2018, 11:12 AM

accept as portmgr for the flavors part.

This revision is now accepted and ready to land.Apr 18 2018, 11:12 AM
Closed by commit rP468608: Flavorize deskutils/znotes (authored by tcberner). · Explain WhyApr 29 2018, 7:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
deskutils/
znotes/
24 lines
5 lines
3 lines

Diff 40182

View Options

deskutils/znotes/Makefile

Loading...
View Options

deskutils/znotes/distinfo

Loading...
View Options

deskutils/znotes/files/

Loading...
View Options

deskutils/znotes/files/patch-single__inst_qtlocalpeer.cpp

Loading...
View Options

deskutils/znotes/pkg-plist

Loading...