deskutils/znotes/Makefile
5 ↗	(On Diff #40182)	instead of bumping you should maybe change the version number to the something like `0.4.5.20150825`
29 ↗	(On Diff #40182)	^ is this really needed? It should find LRELEASE on its own.

tcberner added inline comments.Mar 12 2018, 6:22 AM

deskutils/znotes/Makefile
5 ↗	(On Diff #40182)	See: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex2

tcberner added inline comments.Mar 12 2018, 7:06 AM

deskutils/znotes/Makefile
35 ↗	(On Diff #40182)	^ propbably you want either to get rid of the NLS option, or move the linguist* deps to `NLS_USE=QT[45]=...`

mat added inline comments.Mar 12 2018, 10:23 AM

deskutils/znotes/Makefile
5 ↗	(On Diff #40182)	it's not a question of "should maybe change" it is a question of must. The upstream version is not the same, so the port version must be updated.
25 ↗	(On Diff #40182)	Yes, please.

Done. :-)

Harbormaster completed remote builds in B15523: Diff 40217.Mar 12 2018, 8:10 PM

Should I set Qt5 as default FLAVOR?

Thanks!

This looks good. We currently do not accept flavors that add new packages though, so this change will be able to go in when ports-mgmt/poudriere is updated to 3.3.

Updating new maintainer (me) e-mail address.

Thanks! :-D

Harbormaster completed remote builds in B15558: Diff 40275.Mar 14 2018, 4:55 AM

I guess I will commit this after poudriere 3.3 has landed then, ok?