Page MenuHomeFreeBSD
Differential D14639

Add myself (fernape) to the commiters-port.dot file As per Committers guide, chapter 6, 5 "Update Mentor and Mentee Information"
ClosedPublic
Actions

Authored by fernape on Mar 10 2018, 6:57 PM.
Tags
None
Referenced Files
F151299824: D14639.id.diff
Tue, Apr 7, 10:24 AM
F151259554: D14639.id.diff
Tue, Apr 7, 4:19 AM
Unknown Object (File)
Mon, Apr 6, 4:39 AM
Unknown Object (File)
Fri, Apr 3, 4:54 PM
Unknown Object (File)
Thu, Apr 2, 9:34 PM
Unknown Object (File)
Thu, Mar 26, 9:16 AM
Unknown Object (File)
Thu, Mar 26, 6:17 AM
Unknown Object (File)
Sun, Mar 22, 7:42 AM
View All Files
Subscribers
imp

Details

Reviewers
tz
tcberner
Commits
rS330765: Add myself (fernape) to commiters-port.dot
Summary

Add myself (fernape) to the commiters-port.dot file

Test Plan

run dot -T png -o file.png committers-ports.dot and inspect file.png

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15476
Build 15520: arc lint + arc unit

Event Timeline

fernape created this revision.Mar 10 2018, 6:57 PM
Harbormaster completed remote builds in B15470: Diff 40134.Mar 10 2018, 6:57 PM
tcberner requested changes to this revision.Mar 10 2018, 7:03 PM
tcberner added inline comments.
share/misc/committers-ports.dot
106

^ \n

This revision now requires changes to proceed.Mar 10 2018, 7:03 PM
fernape updated this revision to Diff 40140.Mar 10 2018, 10:55 PM

Add missing \n as pointed out by tcberner.

Checked that I show up at the bottom of the picture hanging from tcberner
and tz.

Updating D14639: Add myself (fernape) to the commiters-port.dot file

As per Committers guide, chapter 6, 5 "Update Mentor and Mentee Information"

Herald added a subscriber: imp. · View Herald TranscriptMar 10 2018, 10:55 PM
Harbormaster completed remote builds in B15476: Diff 40140.Mar 10 2018, 10:55 PM
tcberner accepted this revision.Mar 11 2018, 8:01 AM

Looks good now.

This revision is now accepted and ready to land.Mar 11 2018, 8:01 AM
Closed by commit rS330765: Add myself (fernape) to commiters-port.dot (authored by fernape). · Explain WhyMar 11 2018, 10:47 AM
This revision was automatically updated to reflect the committed changes.
fernape marked an inline comment as done.

Revision Contents
Changeset List

PathSize
share/
misc/
4 lines

Diff 40140

View Options

share/misc/committers-ports.dot

Loading...