Add myself (fernape) to the commiters-port.dot file As per Committers guide, chapter 6, 5 "Update Mentor and Mentee Information"
ClosedPublic
Actions

Authored by fernape on Mar 10 2018, 6:57 PM.

Details

Reviewers

tz
tcberner

Commits

rS330765: Add myself (fernape) to commiters-port.dot

Summary

Add myself (fernape) to the commiters-port.dot file

Test Plan

run dot -T png -o file.png committers-ports.dot and inspect file.png

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15470
Build 15514: arc lint + arc unit

Event Timeline

fernape created this revision.Mar 10 2018, 6:57 PM

Harbormaster completed remote builds in B15470: Diff 40134.Mar 10 2018, 6:57 PM

tcberner requested changes to this revision.Mar 10 2018, 7:03 PM

tcberner added inline comments.

share/misc/committers-ports.dot
106	^ \n

This revision now requires changes to proceed.Mar 10 2018, 7:03 PM

Add missing \n as pointed out by tcberner.

Checked that I show up at the bottom of the picture hanging from tcberner
and tz.

Updating D14639: Add myself (fernape) to the commiters-port.dot file

As per Committers guide, chapter 6, 5 "Update Mentor and Mentee Information"

Herald added a subscriber: imp. · View Herald TranscriptMar 10 2018, 10:55 PM

Harbormaster completed remote builds in B15476: Diff 40140.Mar 10 2018, 10:55 PM

Looks good now.

This revision is now accepted and ready to land.Mar 11 2018, 8:01 AM

Closed by commit rS330765: Add myself (fernape) to commiters-port.dot (authored by fernape). · Explain WhyMar 11 2018, 10:47 AM

This revision was automatically updated to reflect the committed changes.

fernape marked an inline comment as done.

Revision Contents
Changeset List

Path

Size

share/

misc/

committers-ports.dot

4 lines

Diff 40134

View Options

share/misc/committers-ports.dot

Add myself (fernape) to the commiters-port.dot file As per Committers guide, chapter 6, 5 "Update Mentor and Mentee Information"ClosedPublicActions