Page MenuHomeFreeBSD
Differential D1974

Support out-of-tree binutils with in-tree compiler
ClosedPublic
Actions

Authored by emaste on Feb 26 2015, 7:43 PM.
Tags
None
Referenced Files
F170573423: D1974.id.diff
Sat, Sep 5, 11:32 AM
F170550071: D1974.diff
Sat, Sep 5, 8:59 AM
F170503046: D1974.id3998.diff
Sat, Sep 5, 3:24 AM
F170429372: D1974.diff
Fri, Sep 4, 7:13 PM
Unknown Object (File)
Fri, Sep 4, 1:40 AM
Unknown Object (File)
Wed, Sep 2, 5:03 PM
Unknown Object (File)
Tue, Sep 1, 9:03 PM
Unknown Object (File)
Tue, Sep 1, 8:17 PM
View All Files
Subscribers
andrew
freebsd-toolchain-list
imp

Details

Reviewers
bapt
imp
Commits
rS279328: Support CROSS_BINUTILS_PREFIX with in-tree compiler
Summary

Right now CROSS_BINUTILS_PATH is honoured only when XCC is set, i.e. an out-of-tree compiler. Allow CROSS_BINUTILS_PATH to pass through to a -B option also when using the in-tree compiler.

I think this could be named just BINUTILS_PATH, but the existing CROSS_BINUTILS_PATH could as well. Since they have the same meaning I used the existing, if somewhat confusing, name.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 3998.Feb 26 2015, 7:43 PM
emaste retitled this revision from to Support out-of-tree binutils with in-tree compiler.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: bapt.
emaste added a subscriber: Unknown Object (MLST).
emaste added a subscriber: andrew.Feb 26 2015, 7:49 PM
emaste added a comment.Feb 26 2015, 7:53 PM

This supports aarch64 builds by installing the aarch64-binutils port and adding CROSS_BINUTILS_PREFIX=/usr/local/aarch64-freebsd/bin/ to the make command line.

bapt accepted this revision.Feb 26 2015, 7:55 PM
bapt edited edge metadata.

Looks ok to me

This revision is now accepted and ready to land.Feb 26 2015, 7:55 PM
imp accepted this revision.Feb 26 2015, 7:56 PM
imp added a reviewer: imp.
imp added a subscriber: imp.

looks good to me. I've reviewed this in the past as well...

emaste closed this revision.Feb 26 2015, 8:02 PM
emaste updated this revision to Diff 3999.

Closed by commit rS279328 (authored by @emaste).

Revision Contents
Changeset List

PathSize
6 lines

Diff 3998

View Options

Makefile.inc1

Loading...