Page MenuHomeFreeBSD

Precisions/caveat for 30.8 Diskless Operation
ClosedPublic

Authored by rodrigo on Feb 12 2018, 8:37 PM.
Tags
None
Referenced Files
F106113958: D14336.diff
Wed, Dec 25, 3:11 PM
Unknown Object (File)
Thu, Dec 5, 9:11 AM
Unknown Object (File)
Nov 21 2024, 10:52 PM
Unknown Object (File)
Nov 4 2024, 5:12 AM
Unknown Object (File)
Oct 16 2024, 12:39 AM
Unknown Object (File)
Sep 23 2024, 5:24 AM
Unknown Object (File)
Sep 21 2024, 5:58 PM
Unknown Object (File)
Sep 17 2024, 3:15 PM
Subscribers

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adridg added inline comments.
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
3946 ↗(On Diff #39220)

Although *make* is the command, logically *make install* is the command-to-which-you-add-DESTDIR; I would move the *install* inside <command>.

4023 ↗(On Diff #39220)

putting *the number of 512 byte sectors needed (e.g. 5 megabytes is 10240 sectors)* in

Scans better for me and includes an example.

I found a superfluous space (in addition to what @adridg has found.
Try checking it with textproc/igor, there might be additional output/suggestions.

en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
4023 ↗(On Diff #39220)

no space before the comma

ian added inline comments.
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
3946 ↗(On Diff #39220)

No, "make install" is not literally the command; "make installworld", "make installkernel", and "make distribution" are, collectively, "the make install commands".

en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
3946 ↗(On Diff #39220)

@ian, does something like this sounds better ?
(I split it in several lines intentionally to make it more readable)

but do not forget to add 
<option>DESTDIR=<replaceable>${NFSROOTDOR} </replaceable></option>
when running the 
<command>make installkernel</command>
and 
<command>make installworld</command> 
commands.

I found a typo...

en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
3946 ↗(On Diff #39220)

s/NFSROOTDOR/NFSROOTDIR/

;-)

Fix reported issues and make igor happy as much as possible

ian added inline comments.
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
3946 ↗(On Diff #39220)

Yes, that's good.

This revision is now accepted and ready to land.Mar 2 2018, 11:03 PM

@bcr, @sevan : a formal approval from a doc committer would be appreciated.

en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
2522 ↗(On Diff #39545)

No objection to the changes, just one minor nit.
Does the actual command output state "doesn't" or has the text outputs since been changed?

This revision now requires review to proceed.Mar 5 2018, 1:51 AM
rodrigo added inline comments.
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
2522 ↗(On Diff #39545)

You're completely right, this is an unwanted change.

This revision is now accepted and ready to land.Mar 5 2018, 1:57 AM
This revision was automatically updated to reflect the committed changes.