Review for PR 213175
Details
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 14985 Build 15095: arc lint + arc unit
Event Timeline
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml | ||
---|---|---|
3946 | Although *make* is the command, logically *make install* is the command-to-which-you-add-DESTDIR; I would move the *install* inside <command>. | |
4023 |
Scans better for me and includes an example. |
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml | ||
---|---|---|
3946 | No, "make install" is not literally the command; "make installworld", "make installkernel", and "make distribution" are, collectively, "the make install commands". |
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml | ||
---|---|---|
3946 | @ian, does something like this sounds better ? but do not forget to add <option>DESTDIR=<replaceable>${NFSROOTDOR} </replaceable></option> when running the <command>make installkernel</command> and <command>make installworld</command> commands. |
I found a typo...
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml | ||
---|---|---|
3946 | s/NFSROOTDOR/NFSROOTDIR/ ;-) |
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml | ||
---|---|---|
3946 | Yes, that's good. |
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml | ||
---|---|---|
2522 | No objection to the changes, just one minor nit. |
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml | ||
---|---|---|
2522 | You're completely right, this is an unwanted change. |