Differential D14482

libsa: Const-ify buffer argument of write(2) analog
ClosedPublic
Actions

Authored by cem on Feb 23 2018, 5:32 AM.

Tags

None

Referenced Files

	F169623644: D14482.id39639.diff
	Wed, Sep 2, 2:35 AM

	F169416318: D14482.diff
	Tue, Sep 1, 12:01 PM

	F169400954: D14482.id.diff
	Tue, Sep 1, 10:41 AM

	Unknown Object (File)
	Mon, Aug 31, 6:54 AM

	Unknown Object (File)
	Mon, Aug 31, 2:32 AM

	Unknown Object (File)
	Sun, Aug 30, 12:01 PM

	Unknown Object (File)
	Sun, Aug 30, 10:27 AM

	Unknown Object (File)
	Sun, Aug 30, 10:27 AM

Subscribers

Details

Reviewers

imp
kevans
eadler
delphij

Commits

rS329879: libsa: Const-ify buffer argument of write(2) analog

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Feb 23 2018, 5:32 AM

Herald added a subscriber: delphij. · View Herald TranscriptFeb 23 2018, 5:32 AM

Harbormaster completed remote builds in B15221: Diff 39639.Feb 23 2018, 5:32 AM

eadler accepted this revision.Feb 23 2018, 5:51 AM

This revision is now accepted and ready to land.Feb 23 2018, 5:51 AM

delphij accepted this revision.Feb 23 2018, 7:45 AM

+1000, especially on removing the stub write implementations in favor of null_write... I'm not proud of host_write having thrown me off for as long as it did.

imp accepted this revision.Feb 23 2018, 2:47 PM

kevans added a child revision: D14478: liblua: Implement write support.Feb 23 2018, 8:14 PM

Closed by commit rS329879: libsa: Const-ify buffer argument of write(2) analog (authored by cem). · Explain WhyFeb 23 2018, 8:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

libsa/

5 lines

12 lines

2 lines

4 lines

7 lines

11 lines

5 lines

userboot/

userboot/

12 lines

zfs/

13 lines

Diff 39662

head/stand/libsa/cd9660.c

Loading...

head/stand/libsa/nfs.c

Loading...

head/stand/libsa/nullfs.c

Loading...

head/stand/libsa/stand.h

Loading...

head/stand/libsa/tftp.c

Loading...

head/stand/libsa/ufs.c

Loading...

head/stand/libsa/write.c

Loading...

head/stand/userboot/userboot/host.c

Loading...

head/stand/zfs/zfs.c

Loading...