Page MenuHomeFreeBSD
Differential D14482

libsa: Const-ify buffer argument of write(2) analog
ClosedPublic
Actions

Authored by cem on Feb 23 2018, 5:32 AM.
Tags
None
Referenced Files
F156981488: D14482.diff
Sun, May 17, 7:04 PM
F156981459: D14482.diff
Sun, May 17, 7:04 PM
Unknown Object (File)
Thu, Apr 30, 12:52 AM
Unknown Object (File)
Mon, Apr 27, 6:39 PM
Unknown Object (File)
Sat, Apr 25, 6:45 AM
Unknown Object (File)
Thu, Apr 23, 7:11 AM
Unknown Object (File)
Tue, Apr 21, 11:21 AM
Unknown Object (File)
Tue, Apr 21, 11:21 AM
View All 98 Files
Subscribers
delphij

Details

Reviewers
imp
kevans
eadler
delphij
Commits
rS329879: libsa: Const-ify buffer argument of write(2) analog

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15221
Build 15289: arc lint + arc unit

Event Timeline

cem created this revision.Feb 23 2018, 5:32 AM
Herald added a subscriber: delphij. · View Herald TranscriptFeb 23 2018, 5:32 AM
Harbormaster completed remote builds in B15221: Diff 39639.Feb 23 2018, 5:32 AM
eadler accepted this revision.Feb 23 2018, 5:51 AM
This revision is now accepted and ready to land.Feb 23 2018, 5:51 AM
delphij accepted this revision.Feb 23 2018, 7:45 AM
kevans accepted this revision.Feb 23 2018, 12:55 PM

+1000, especially on removing the stub write implementations in favor of null_write... I'm not proud of host_write having thrown me off for as long as it did.

imp accepted this revision.Feb 23 2018, 2:47 PM
kevans added a child revision: D14478: liblua: Implement write support.Feb 23 2018, 8:14 PM
Closed by commit rS329879: libsa: Const-ify buffer argument of write(2) analog (authored by cem). · Explain WhyFeb 23 2018, 8:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stand/
libsa/
5 lines
12 lines
2 lines
4 lines
7 lines
11 lines
5 lines
userboot/
userboot/
12 lines
zfs/
13 lines

Diff 39639

View Options

stand/libsa/cd9660.c

Loading...
View Options

stand/libsa/nfs.c

Loading...
View Options

stand/libsa/nullfs.c

Loading...
View Options

stand/libsa/stand.h

Loading...
View Options

stand/libsa/tftp.c

Loading...
View Options

stand/libsa/ufs.c

Loading...
View Options

stand/libsa/write.c

Loading...
View Options

stand/userboot/userboot/host.c

Loading...
View Options

stand/zfs/zfs.c

Loading...