Details
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 14987 Build 15097: arc lint + arc unit
Event Timeline
| sys/sys/msg.h | ||
|---|---|---|
| 133 | I would perhaps use slightly-less fine-grained macros. E.g. a single _WANT_SYSVMSG for this file. | |
| sys/sys/msg.h | ||
|---|---|---|
| 154 | You can drop this and the above #endif now I think? | |
| 174 | Maybe blank lines around the #else as there is in sem.h (and then keep the blank line before the #endif)? I find that a bit easier to read. | |
| sys/sys/sem.h | ||
| 124 | Here as well. | |
| 135 | Here. | |
| sys/sys/shm.h | ||
| 127 | Can collapse this #endif and #if. | |
| 133 | I think for this I would actually prefer to always use the 'struct vm_object;' forward declare and then use 'struct vm_object *' instead of 'vm_object_t'. I feel like we do this in some other places in the kernel where we export a structure to userland, e.g. for 'td_kstack_obj' in 'struct thread'. That would mean you wouldn't need the #include of <vm/vm.h> or the #ifdef at all. | |
| usr.bin/ipcs/ipc.h | ||
| 71 | Oh wow, that was gross (ipcs depending on the kernel externs) | |