Get rid of the requirement to include SysV IPC headers with _KERNEL defined in ipcrm by introducing a number of _WANT_foo defines.

[brooks]

Rebase to remove already committed changes.

[jhb]

sys/sys/msg.h

133

I would perhaps use slightly-less fine-grained macros. E.g. a single _WANT_SYSVMSG for this file.

[brooks]

• Replace assorted _WANT defines with _WANT_SYSV(IPC|MSG_SEM_SHM)_INTERNALS.

[jhb]

sys/sys/msg.h

153

You can drop this and the above #endif now I think?

176

Maybe blank lines around the #else as there is in sem.h (and then keep the blank line before the #endif)? I find that a bit easier to read.

sys/sys/sem.h

123

Here as well.

132

Here.

sys/sys/shm.h

127

Can collapse this #endif and #if.

133

I think for this I would actually prefer to always use the 'struct vm_object;' forward declare and then use 'struct vm_object *' instead of 'vm_object_t'. I feel like we do this in some other places in the kernel where we export a structure to userland, e.g. for 'td_kstack_obj' in 'struct thread'. That would mean you wouldn't need the #include of <vm/vm.h> or the #ifdef at all.

usr.bin/ipcs/ipc.h

71

Oh wow, that was gross (ipcs depending on the kernel externs)

[brooks]

• Consolidate ifdef blocks.

[brooks]

Tidied up. Thanks for the suggestions.