Page MenuHomeFreeBSD
Differential D14131

Correct check for nullptr to fix build with clang 6.
ClosedPublic
Actions

Authored by jhb on Jan 30 2018, 4:26 PM.
Tags
None
Referenced Files
F163394561: D14131.id.diff
Wed, Jul 22, 7:58 PM
Unknown Object (File)
Tue, Jul 21, 11:56 AM
Unknown Object (File)
Sat, Jul 18, 3:19 AM
Unknown Object (File)
Fri, Jul 10, 4:33 PM
Unknown Object (File)
Thu, Jul 9, 6:15 AM
Unknown Object (File)
Sat, Jul 4, 11:37 AM
Unknown Object (File)
Fri, Jul 3, 12:34 PM
Unknown Object (File)
Fri, Jul 3, 8:00 AM
View All Files
Subscribers
mat

Details

Reviewers
sbruno
bdrewery
Commits
rP460499: Fix nullptr definition buildfailure on current with clang6
Summary

Check __cplusplus version to determine presence of nullptr rather than
assuming nullptr is a cpp macro.

This should probably be posted upstream as well.

Test Plan
  • build port with recent head

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14675
Build 14803: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 30 2018, 4:26 PM
Harbormaster completed remote builds in B14675: Diff 38676.Jan 30 2018, 4:26 PM
Herald added a subscriber: mat. · View Herald TranscriptJan 30 2018, 4:26 PM
sbruno added a comment.Jan 30 2018, 6:25 PM

I'll run this through my local meat grinder and approve/commit after. THANKS

sbruno accepted this revision.Jan 31 2018, 4:33 PM
This revision is now accepted and ready to land.Jan 31 2018, 4:33 PM
Closed by commit rP460499: Fix nullptr definition buildfailure on current with clang6 (authored by sbruno). · Explain WhyJan 31 2018, 4:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sysutils/
synergy/
files/
11 lines

Diff 38676

View Options

sysutils/synergy/files/patch-src_lib_common_common.h

Loading...