Correct check for nullptr to fix build with clang 6.
ClosedPublic
Actions

Authored by jhb on Jan 30 2018, 4:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 9 2024, 6:48 PM

	Unknown Object (File)
	Feb 9 2024, 8:47 AM

	Unknown Object (File)
	Feb 9 2024, 8:47 AM

	Unknown Object (File)
	Feb 9 2024, 8:47 AM

	Unknown Object (File)
	Feb 8 2024, 9:35 PM

	Unknown Object (File)
	Jan 31 2024, 5:24 PM

	Unknown Object (File)
	Dec 20 2023, 3:07 AM

	Unknown Object (File)
	Nov 30 2023, 10:14 PM

View All 27 Files

Subscribers

mat

Details

Reviewers

sbruno
bdrewery

Commits

rP460499: Fix nullptr definition buildfailure on current with clang6

Summary

Check __cplusplus version to determine presence of nullptr rather than
assuming nullptr is a cpp macro.

This should probably be posted upstream as well.

Test Plan

build port with recent head

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 30 2018, 4:26 PM

Harbormaster completed remote builds in B14675: Diff 38676.Jan 30 2018, 4:26 PM

Herald added a subscriber: mat. · View Herald TranscriptJan 30 2018, 4:26 PM

I'll run this through my local meat grinder and approve/commit after. THANKS

sbruno accepted this revision.Jan 31 2018, 4:33 PM

This revision is now accepted and ready to land.Jan 31 2018, 4:33 PM

Closed by commit rP460499: Fix nullptr definition buildfailure on current with clang6 (authored by sbruno). · Explain WhyJan 31 2018, 4:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sysutils/

synergy/

files/

patch-src_lib_common_common.h

11 lines

Diff 38727

View Options

head/sysutils/synergy/files/patch-src_lib_common_common.h

Correct check for nullptr to fix build with clang 6.ClosedPublicActions