Page MenuHomeFreeBSD
Differential D13959

Convert ls(1) to not use libxo(3).
ClosedPublic
Actions

Authored by cem on Jan 17 2018, 8:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 7, 3:42 AM
Unknown Object (File)
Tue, Oct 6, 12:24 PM
Unknown Object (File)
Tue, Sep 22, 12:22 AM
Unknown Object (File)
Fri, Sep 18, 12:56 PM
Unknown Object (File)
Aug 9 2026, 4:05 PM
Unknown Object (File)
Aug 9 2026, 1:01 PM
Unknown Object (File)
Aug 9 2026, 9:15 AM
Unknown Object (File)
Aug 9 2026, 4:08 AM
View All Files
Subscribers
None

Details

Reviewers
manu
imp
kmacy
Group Reviewers
manpages
Commits
rS328100: Convert ls(1) to not use libxo(3)
Summary

libxo imposes a large burden on system utilities. In the case of ls, that
burden is difficult to justify -- any language that can interact with json
output can use readdir(3) and stat(2).

Logically revert r291607, r285857, r285803, r285734, r285425, r284494, r284489,
r284252, and r284198.

Test Plan
$ id
uid=0(root) gid=0(wheel) groups=0(wheel),5(operator)
$ kyua test
...
35/35 passed (0 failed)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14447
Build 14594: arc lint + arc unit

Event Timeline

cem created this revision.Jan 17 2018, 8:52 PM
Herald added a reviewer: manpages. · View Herald TranscriptJan 17 2018, 8:52 PM
Harbormaster completed remote builds in B14447: Diff 38109.Jan 17 2018, 8:52 PM
cem added a reviewer: kmacy.Jan 17 2018, 9:12 PM
imp accepted this revision.Jan 17 2018, 10:34 PM

My only regret is that phab won't let me click accept twice.

This revision is now accepted and ready to land.Jan 17 2018, 10:34 PM
Closed by commit rS328100: Convert ls(1) to not use libxo(3) (authored by cem). · Explain WhyJan 17 2018, 10:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
bin/
ls/
2 lines
1 line
11 lines
3 lines
12 lines
57 lines
205 lines
52 lines

Diff 38109

View Options

bin/ls/Makefile

Loading...
View Options

bin/ls/Makefile.depend

Loading...
View Options

bin/ls/extern.h

Loading...
View Options

bin/ls/ls.h

Loading...
View Options

bin/ls/ls.1

Loading...
View Options

bin/ls/ls.c

Loading...
View Options

bin/ls/print.c

Loading...
View Options

bin/ls/util.c

Loading...