- update deskutils/py-khal to 0.9.8 version
- switch it to DISTVERSION
- some minor alphabetizing
- add new dependencies
- added an OPTION to setproctile
Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 14372 Build 14527: arc lint + arc unit
Event Timeline
deskutils/py-khal/Makefile | ||
---|---|---|
30 | ^ I think the lowest version at the moment is 3.4 -- so why the change? |
Yes, this patch started for a older version. I forgot to update the minimum python version to python:3.4+.
Thanks!
deskutils/py-khal/Makefile | ||
---|---|---|
2 | ^unless this is you, or you have the permission, you are not allowed to remove the "created by" line :) |
I am out now and so I can't look for, but shouldn't the port header be cleanased and leave only the "# $freebsd$" line?
Doesn't that include removing that "created by" line?
Thanks!
deskutils/py-khal/Makefile | ||
---|---|---|
36 | Empty, remove. |
deskutils/py-khal/Makefile | ||
---|---|---|
47 | I would be really surprised if this worked. |
deskutils/py-khal/Makefile | ||
---|---|---|
47 | In short you mean this also needs "devel/py-pytest" and "devel/py-pytest-runner" for v0.9.8? |
There are two different kind of errors here:
- the filesystem of the build service doesn't seem to support mtime of files, while we could mock this, it's kind of the point to test if an updated file is caught my khal. Do you know what kind of system the build is run on?
- the locale seems to be not/misconfigured, exporting the correct locale settings should fix those errors, something like exporting LC_ALL=en_US.utf-8 and LANG=en_US.utf-8 should do the tick ( see http://click.pocoo.org/5/python3/#python-3-surrogate-handling )
As the first issue is not easily fixable, I would suggest either patching the tests to make them xfail or not run them for now.
deskutils/py-khal/Makefile | ||
---|---|---|
47 | The new setup.cfg file is also needed (if FreeBSD doesn't have anything in place to autodiscover that setting which I don't know about). |
- FreeBSD workstation.privacychain.ch 11.1-RELEASE-p6 FreeBSD 11.1-RELEASE-p6 #0 r326729: Sat Dec 9 13:58:14 -02 2017 root@workstation.privacychain.ch:/usr/obj/usr/src/sys/GENERIC amd64
- Locale: LANG=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 LC_COLLATE=C LC_TIME=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_MONETARY=pt_BR.UTF-8 LC_MESSAGES=en_US.UTF-8 LC_ALL=
I also tried with LC_ALL="en_US.UTF-8", same thing as far I remember.
Thanks!
I'll have a look at this later, I'll keep track of this in khal's issue tracker (see https://github.com/pimutils/khal/issues/745 ).
Please double-check upstream's comment about setup.cfg.
deskutils/py-khal/Makefile | ||
---|---|---|
47 | I recall there being a new file to install, some sample config file. It looks like that got lost when dropping the do-test target. |
It's not needed when the tests are not run via the ports framework (which doesn't work atm, see https://github.com/pimutils/khal/issues/745 ).
This is a code review tool, not a bug tracker, people opening code reviews are usually responsible for committing the changes. If you are not a committer, using the code review is good, but you should probably open a PR in the end with the final patch so that it gets in the queue.
Built and installed naively it refuses to run until I set LANG to a UTF-8 locale (e.g. en_US.UTF-8), but that's more a Python 3.6 / Click problem than khal.
I am marking those are "Done" since the subject was already discussed.
Will wait @github_lostpackets.de say something about the last issues pointed by @adridg, and if necessary add in a pkg-message or what be more correct.
Thanks!