Page MenuHomeFreeBSD
Differential D13769

Fix databases/soci build w/ clang.
ClosedPublic
Actions

Authored by adridg on Jan 4 2018, 8:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 8, 8:12 PM
Unknown Object (File)
Tue, Sep 8, 4:17 PM
Unknown Object (File)
Tue, Sep 8, 6:10 AM
Unknown Object (File)
Mon, Sep 7, 11:33 PM
Unknown Object (File)
Mon, Sep 7, 12:34 PM
Unknown Object (File)
Sun, Sep 6, 12:53 PM
Unknown Object (File)
Sat, Sep 5, 11:00 PM
Unknown Object (File)
Sat, Sep 5, 3:39 PM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
rakuco
jlaffaye
Commits
rP458126: Fix build of databases/soci w/ clang 4.0 and later and on arm6, arm7.
Summary

Add upstream patch that fixes bogus pointer-vs-int comparison.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14121
Build 14296: arc lint + arc unit

Event Timeline

adridg created this revision.Jan 4 2018, 8:39 PM
Herald added a subscriber: mat. · View Herald TranscriptJan 4 2018, 8:39 PM
Harbormaster completed remote builds in B14120: Diff 37529.Jan 4 2018, 8:39 PM
adridg updated this revision to Diff 37530.Jan 4 2018, 8:41 PM

Come to think of it, if this previously compiled, the comparison
would be wrong and it's a bug which can mis-report an error.
While here, drop the BROKEN lines, since this fixes exactly that error.

Harbormaster completed remote builds in B14121: Diff 37530.Jan 4 2018, 8:41 PM
tcberner accepted this revision.Jan 4 2018, 9:12 PM

Looks good from my side.

This revision is now accepted and ready to land.Jan 4 2018, 9:12 PM
jlaffaye accepted this revision.Jan 5 2018, 7:50 AM

LGTM

Closed by commit rP458126: Fix build of databases/soci w/ clang 4.0 and later and on arm6, arm7. (authored by adridg). · Explain WhyJan 5 2018, 11:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
databases/
soci/
5 lines
files/
14 lines

Diff 37530

View Options

databases/soci/Makefile

Loading...
View Options

databases/soci/files/patch-backends_mysql_session.cpp

Loading...