clang.
ClosedPublic
Actions

Authored by adridg on Jan 4 2018, 8:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 3, 11:48 PM

	Unknown Object (File)
	Thu, Oct 1, 10:12 AM

	Unknown Object (File)
	Tue, Sep 29, 1:50 AM

	Unknown Object (File)
	Sun, Sep 27, 3:32 AM

	Unknown Object (File)
	Wed, Sep 23, 3:16 PM

	Unknown Object (File)
	Wed, Sep 16, 9:18 PM

	Unknown Object (File)
	Wed, Sep 16, 8:29 PM

	Unknown Object (File)
	Mon, Sep 14, 2:08 PM

View All Files

Subscribers

mat

Details

Reviewers

tcberner
rakuco
jlaffaye

Commits

rP458126: Fix build of databases/soci w/ clang 4.0 and later and on arm6, arm7.

Summary

Add upstream patch that fixes bogus pointer-vs-int comparison.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 14120
Build 14295: arc lint + arc unit

Event Timeline

adridg created this revision.Jan 4 2018, 8:39 PM

Herald added a subscriber: mat. · View Herald TranscriptJan 4 2018, 8:39 PM

Harbormaster completed remote builds in B14120: Diff 37529.Jan 4 2018, 8:39 PM

Come to think of it, if this previously compiled, the comparison
would be wrong and it's a bug which can mis-report an error.
While here, drop the BROKEN lines, since this fixes exactly that error.

Harbormaster completed remote builds in B14121: Diff 37530.Jan 4 2018, 8:41 PM

Looks good from my side.

This revision is now accepted and ready to land.Jan 4 2018, 9:12 PM

LGTM

Closed by commit rP458126: Fix build of databases/soci w/ clang 4.0 and later and on arm6, arm7. (authored by adridg). · Explain WhyJan 5 2018, 11:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

databases/

soci/

files/

patch-backends_mysql_session.cpp

14 lines

Diff 37529

View Options

databases/soci/files/patch-backends_mysql_session.cpp

Fix databases/soci build w/ clang.ClosedPublicActions