Differential D13664

stand/fdt: Consistently apply fdt_overlays
ClosedPublic
Actions

Authored by kevans on Dec 28 2017, 2:46 PM.

Tags

None

Referenced Files

	F87388907: D13664.id.diff
	Tue, Jul 2, 12:47 PM

	F87388902: D13664.id37136.diff
	Tue, Jul 2, 12:47 PM

	F87388897: D13664.id37137.diff
	Tue, Jul 2, 12:47 PM

	F87388892: D13664.id37185.diff
	Tue, Jul 2, 12:47 PM

	F87387892: D13664.diff
	Tue, Jul 2, 12:31 PM

	Unknown Object (File)
	Sun, Jun 30, 7:27 PM

	Unknown Object (File)
	Fri, Jun 28, 12:29 PM

	Unknown Object (File)
	Fri, Jun 28, 1:16 AM

View All 51 Files

Subscribers

Details

Reviewers

manu
gonzo
imp

Commits

rS327350: stand/fdt: Consistently apply fdt_overlays

Summary

Overlays were previously not applied when U-Boot provides FDT or EFI provides FDT, only when we load FDT from /boot/dtb given name from U-Boot. Make all three paths lead to loading fdt_overlays and applying them, so that fdt_overlays can be expected to Just Work.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 13893

Event Timeline

kevans created this revision.Dec 28 2017, 2:46 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 28 2017, 2:46 PM

manu added inline comments.Dec 28 2017, 2:52 PM

stand/efi/fdt/efi_fdt.c
52	if (hdr == NULL) return (1);

Address manu@'s comment, rework flow to just return early in case of errors.

manu accepted this revision.Dec 28 2017, 3:14 PM

This revision is now accepted and ready to land.Dec 28 2017, 3:14 PM

imp accepted this revision.Dec 28 2017, 4:57 PM

kevans mentioned this in D13659: stand/fdt: Fix loading of multiple fdt_overlays.Dec 28 2017, 9:02 PM

gonzo accepted this revision.Dec 28 2017, 9:12 PM

Closed by commit rS327350: stand/fdt: Consistently apply fdt_overlays (authored by kevans). · Explain WhyDec 29 2017, 6:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

stand/

efi/

fdt/

19 lines

uboot/

fdt/

5 lines

Diff 37136

stand/efi/fdt/efi_fdt.c

Loading...

stand/uboot/fdt/uboot_fdt.c

Loading...