Page MenuHomeFreeBSD
Differential D13599

devel/rapidjson: Fix clang warnings on 12.
ClosedPublic
Actions

Authored by yuri on Dec 23 2017, 9:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 11, 4:05 AM
Unknown Object (File)
Wed, Jun 10, 7:54 PM
Unknown Object (File)
Wed, Jun 10, 9:55 AM
Unknown Object (File)
Thu, Jun 4, 11:05 PM
Unknown Object (File)
Sat, May 16, 10:32 AM
Unknown Object (File)
May 10 2026, 4:18 PM
Unknown Object (File)
May 9 2026, 2:33 PM
Unknown Object (File)
May 9 2026, 1:30 PM
View All Files
Subscribers
mat
tobik

Details

Reviewers
tcberner
adamw
Commits
rP457707: devel/rapidjson: Fix clang warnings on 12
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220388

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13771
Build 13985: arc lint + arc unit

Event Timeline

yuri created this revision.Dec 23 2017, 9:16 PM
Herald added a subscriber: mat. · View Herald TranscriptDec 23 2017, 9:16 PM
adamw added inline comments.Dec 23 2017, 10:23 PM
devel/rapidjson/Makefile
31

Are you sure you want to still define DATADIR and PORTDATA after including bsd.port.pre.mk? Usually that is included as late as possible.

tobik added a subscriber: tobik.Dec 24 2017, 4:10 PM
tobik added inline comments.
devel/rapidjson/Makefile
17–18

It builds fine on armv7 with Dimitry's patch from the PR applied, so I think BROKEN_armv7 can be removed now.

http://sprunge.us/WAXU

yuri updated this revision to Diff 36968.Dec 24 2017, 5:32 PM

Moved DATADIR and PORTDATA to the earlier location.

Harbormaster completed remote builds in B13770: Diff 36968.Dec 24 2017, 5:32 PM
yuri updated this revision to Diff 36969.Dec 24 2017, 5:33 PM
yuri marked an inline comment as done.

Removed BROKEN_armv7

yuri marked an inline comment as done.Dec 24 2017, 5:33 PM
tobik mentioned this in D13712: multimedia/kodi-devel: Add GBM flavor and prepare for Wayland support.Dec 31 2017, 12:55 PM
tobik added a comment.Dec 31 2017, 1:09 PM

@adamw @tcberner Can you approve? This blocks having a package for kodi-devel on 12.0-CURRENT.

tcberner added inline comments.Dec 31 2017, 2:56 PM
devel/rapidjson/Makefile
40

^ why is this here and not further up i the Makefile?
Also, you can write this as
CMAKE_OFF= RAPIDJSON_BUILD_TESTS
now :D

tcberner accepted this revision.Dec 31 2017, 3:31 PM

Apart from that, it is fine.

This revision is now accepted and ready to land.Dec 31 2017, 3:31 PM
yuri marked an inline comment as done.Dec 31 2017, 5:02 PM
Closed by commit rP457707: devel/rapidjson: Fix clang warnings on 12 (authored by yuri). · Explain WhyDec 31 2017, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
rapidjson/
19 lines
10 lines

Diff 36969

View Options

devel/rapidjson/Makefile

Loading...
View Options

devel/rapidjson/files/

Loading...
View Options

devel/rapidjson/files/patch-include_rapidjson_schema.h

Loading...