Reverse the check to allocate the buffer if cached pointer is NULL.
ClosedPublic
Actions

Authored by kan on Dec 23 2017, 4:41 PM.

Tags

None

Referenced Files

	F169099537: D13596.id36944.diff
	Mon, Aug 31, 10:08 AM

	F169071746: D13596.id36940.diff
	Mon, Aug 31, 8:09 AM

	Unknown Object (File)
	Sun, Aug 30, 2:26 PM

	Unknown Object (File)
	Sun, Aug 30, 1:06 PM

	Unknown Object (File)
	Wed, Aug 26, 8:12 AM

	Unknown Object (File)
	Tue, Aug 25, 7:54 PM

	Unknown Object (File)
	Tue, Aug 25, 10:44 AM

	Unknown Object (File)
	Tue, Aug 25, 10:02 AM

View All Files

Subscribers

imp

Details

Reviewers

rmacklem
kib
emaste

Commits

rS327114: Reverse the check to allocate the buffer if cached pointer is NULL.

Summary

The code previously would allocate the buffer only it if were NOT
NULL. Otherwise it would happily pass NULL pointer to copyinstr
function below.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kan created this revision.Dec 23 2017, 4:41 PM

kan added reviewers: rmacklem, kib, emaste.Dec 23 2017, 4:42 PM

kan set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptDec 23 2017, 4:42 PM

kib accepted this revision.Dec 23 2017, 5:02 PM

This revision is now accepted and ready to land.Dec 23 2017, 5:02 PM

Closed by commit rS327114: Reverse the check to allocate the buffer if cached pointer is NULL. (authored by kan). · Explain WhyDec 23 2017, 5:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

vfs_export.c

2 lines

Diff 36944

View Options

head/sys/kern/vfs_export.c

Reverse the check to allocate the buffer if cached pointer is NULL.ClosedPublicActions