Reverse the check to allocate the buffer if cached pointer is NULL.
ClosedPublic
Actions

Authored by kan on Dec 23 2017, 4:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 28, 5:44 AM

	Unknown Object (File)
	Fri, Nov 21, 6:08 PM

	Unknown Object (File)
	Fri, Nov 21, 3:54 AM

	Unknown Object (File)
	Fri, Nov 21, 3:54 AM

	Unknown Object (File)
	Fri, Nov 21, 3:53 AM

	Unknown Object (File)
	Fri, Nov 21, 3:52 AM

	Unknown Object (File)
	Wed, Nov 19, 2:20 PM

	Unknown Object (File)
	Nov 2 2025, 12:52 PM

View All Files

Subscribers

imp

Details

Reviewers

rmacklem
kib
emaste

Commits

rS327114: Reverse the check to allocate the buffer if cached pointer is NULL.

Summary

The code previously would allocate the buffer only it if were NOT
NULL. Otherwise it would happily pass NULL pointer to copyinstr
function below.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13757
Build 13972: arc lint + arc unit

Event Timeline

kan created this revision.Dec 23 2017, 4:41 PM

kan added reviewers: rmacklem, kib, emaste.Dec 23 2017, 4:42 PM

kan set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptDec 23 2017, 4:42 PM

kib accepted this revision.Dec 23 2017, 5:02 PM

This revision is now accepted and ready to land.Dec 23 2017, 5:02 PM

Closed by commit rS327114: Reverse the check to allocate the buffer if cached pointer is NULL. (authored by kan). · Explain WhyDec 23 2017, 5:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_export.c

2 lines

Diff 36940

View Options

Reverse the check to allocate the buffer if cached pointer is NULL.ClosedPublicActions