Do not double free the memory in if_clone.
ClosedPublic
Actions

Authored by kan on Apr 13 2017, 4:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 17, 11:08 AM

	Unknown Object (File)
	Fri, Apr 17, 4:13 AM

	Unknown Object (File)
	Thu, Apr 16, 10:48 AM

	Unknown Object (File)
	Fri, Apr 10, 4:04 PM

	Unknown Object (File)
	Fri, Apr 10, 8:24 AM

	Unknown Object (File)
	Fri, Apr 10, 2:55 AM

	Unknown Object (File)
	Tue, Apr 7, 11:17 AM

	Unknown Object (File)
	Tue, Apr 7, 7:03 AM

View All Files

Subscribers

imp

Details

Reviewers

glebius
ae

Commits

rS327109: Remove some trailing whitespace.
rS327108: Do not double free the memory in if_clone.

Summary

if_clone_attach function will drop the reference on failure which will
free the if_clone structure. No need to do it second time.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kan created this revision.Apr 13 2017, 4:32 PM

Herald added a subscriber: ae. · View Herald TranscriptApr 13 2017, 4:32 PM

I'm not glebius@, but the patch looks correct.

This revision is now accepted and ready to land.Apr 13 2017, 5:19 PM

Thanks! Please commit whitespace separately from functional changes.

Closed by commit rS327108: Do not double free the memory in if_clone. (authored by kan). · Explain WhyDec 23 2017, 4:24 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptDec 23 2017, 4:24 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

if_clone.c

8 lines

Diff 36939

View Options

Do not double free the memory in if_clone.ClosedPublicActions