Page MenuHomeFreeBSD
Differential D10386

Do not double free the memory in if_clone.
ClosedPublic
Actions

Authored by kan on Apr 13 2017, 4:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 9:40 AM
Unknown Object (File)
Mar 7 2024, 5:48 PM
Unknown Object (File)
Jan 29 2024, 11:47 PM
Unknown Object (File)
Dec 22 2023, 9:52 PM
Unknown Object (File)
Dec 18 2023, 10:52 AM
Unknown Object (File)
Sep 28 2023, 3:47 PM
Unknown Object (File)
Aug 10 2023, 5:48 PM
Unknown Object (File)
Aug 10 2023, 5:48 PM
View All 20 Files
Subscribers
ae
imp

Details

Reviewers
glebius
ae
Commits
rS327109: Remove some trailing whitespace.
rS327108: Do not double free the memory in if_clone.
Summary

if_clone_attach function will drop the reference on failure which will
free the if_clone structure. No need to do it second time.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8714
Build 9053: arc lint + arc unit

Event Timeline

kan created this revision.Apr 13 2017, 4:32 PM
Herald added a subscriber: ae. · View Herald TranscriptApr 13 2017, 4:32 PM
ae accepted this revision.Apr 13 2017, 5:19 PM

I'm not glebius@, but the patch looks correct.

This revision is now accepted and ready to land.Apr 13 2017, 5:19 PM
glebius accepted this revision.Apr 25 2017, 4:23 PM

Thanks! Please commit whitespace separately from functional changes.

Closed by commit rS327108: Do not double free the memory in if_clone. (authored by kan). · Explain WhyDec 23 2017, 4:24 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptDec 23 2017, 4:24 PM

Revision Contents
Changeset List

PathSize
sys/
net/
12 lines

Diff 27414

View Options

sys/net/if_clone.c

Loading...