Reuse kern_proc_vmmap_resident() for procfs_map resident count.
ClosedPublic
Actions

Authored by kib on Dec 23 2017, 12:03 PM.

Details

Reviewers

emaste
glenn.weinberg_intel.com
des

Commits

rS327286: Reuse kern_proc_vmmap_resident() for procfs_map resident count.
rS327285: Make kern_proc_vmmap_resident() externally accesible, and move the

Summary

The existing algorithm in procfs_map() to calculate count of resident pages in an entry is too primitive, resulting in too long run time for large sparse mapping entries. Re-use the kern_proc_vmmap_resident() from kern_proc.c which only looks at the existing pages in the iterations.

Also, this makes procfs to honor kern.proc_vmmap_skip_resident_count, if user does not need this information.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Dec 23 2017, 12:03 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 23 2017, 12:03 PM

Remove redundant check.

No objection from me, but I don't feel competent to review the patch.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 28 2017, 1:16 PM

Closed by commit rS327285: Make kern_proc_vmmap_resident() externally accesible, and move the (authored by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

vangyzen added a subscriber: vangyzen.Feb 27 2019, 8:07 PM

vangyzen added inline comments.

head/sys/kern/kern_proc.c
3142 ↗	(On Diff #37132)	Was this part added by accident? It doesn't seem related. It was added in the final revision of this review. I don't see any revert or discussion on svn-src-{all,head}.

kib added inline comments.Feb 28 2019, 9:58 AM

head/sys/kern/kern_proc.c
3142 ↗	(On Diff #37132)	I think yes, it was accidental. Other than that, I believe that chunk was written for a reason, i.e. I saw a real report of P_TOTAL_STOP leakage. Do you have some troubles caused by it ?

vangyzen added inline comments.Feb 28 2019, 9:49 PM

head/sys/kern/kern_proc.c
3142 ↗	(On Diff #37132)	It's not causing any trouble for me. I just stumbled across it and wanted to make sure you were aware of it. What to do is entirely your call. (It looks fine to me.)