ipfw SCTP grew accidental dependency on full options SCTP stack
AbandonedPublic
Actions

Authored by kbowling on Dec 23 2017, 3:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 8, 9:49 PM

	Unknown Object (File)
	Tue, Apr 23, 8:33 PM

	Unknown Object (File)
	Fri, Apr 19, 2:02 PM

	Unknown Object (File)
	Fri, Apr 19, 2:04 AM

	Unknown Object (File)
	Thu, Apr 18, 10:57 PM

	Unknown Object (File)
	Thu, Apr 18, 2:44 PM

	Unknown Object (File)
	Apr 1 2024, 3:17 AM

	Unknown Object (File)
	Mar 4 2024, 2:42 PM

View All 31 Files

Subscribers

j-nitrology.com

Details

Reviewers

tuexen
sbruno
ae

Commits

rP461011: re-add databases/mongodb36 - it was not repocopied
rP457783: add new port: MongoDB 3.6.0

Summary

I fixed this in the most expedient way, I'm happy to go about it another way if you don't like it

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling created this revision.Dec 23 2017, 3:22 AM

Hi Kevin,

you are right, I missed that. Sorry about that. Let me change the code in sctp_crc32.c such that we don't need any SCTP specific include files anymore. Give me a day or two.

Best regards
Michael

Hi Kevin,

I committed a fix in https://svnweb.freebsd.org/changeset/base/327200. I changed the code in sctp_crc32c.c such that it does not rely on any other SCTP sources. This way it does not require any changes to sctp_os_bsd.h.

Thanks for reporting the issue and providing a suggested solution!

Best regards
Michael

Thanks, your changes worked