After I started playing with linuxulator and xattrs, I found some mistakes in ext2fs and fuse extattrs logic.
Here is fixes for some problems, which I met.
Details
Details
The fuse extattrs tests will be included to test plan for https://reviews.freebsd.org/D13209
when linuxulator xattrs will be finished.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Cosmetic changes don't need to be in the Differential Review: they just distract us from the main changes.
Send me a diff privately and I will approve them.
| fs/fuse/fuse_vnops.c | ||
|---|---|---|
| 1991 | Not enough context, but I assume fdi can be uninitialized. | |
| 2005 | Most of these changes seem cosmetic and should be committed independently. | |
| 2035 | cosmetic. | |
| 2089 | Same as above (cosmetic). | |
| 2307 | I haven't checked if fdi needs to be initialized (perhaps later). | |
Comment Actions
Seems like, it is not clearly understandable what was fixed. Ok, let me explain:
- The was a bug in list() function when uio was not passed, the size of linux list (not converted to bsd was returned).
- Case when neither uio nor size were not passed to list() and get(), this logic could be used to check does extattr with some key exist or not.
If it is strongly required, I can separate the variables initialization and cosmetic to another patch.
So, may be let wait some time the comments from @cem, if not I will send the patch to @pfg for approve.
| fs/fuse/fuse_vnops.c | ||
|---|---|---|
| 1991 | I decided that I will not zero it is because it is not zero it in other places. So, it should be done by fdisp_init(); and fdisp_make_vp(). | |
Comment Actions
Yep, it was spitted to https://reviews.freebsd.org/D13528 and https://reviews.freebsd.org/D13737.
So, it should be abandoned.