Details

Reviewers

tcberner
adamw

Commits

rP455903: New port: graphics/drawpile: Collaborative drawing program

Summary

Collaborative drawing program

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 13406
Build 13637: arc lint + arc unit

Event Timeline

yuri created this revision.Dec 7 2017, 6:20 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 7 2017, 6:20 AM

Harbormaster completed remote builds in B13399: Diff 36332.Dec 7 2017, 6:20 AM

tcberner added inline comments.Dec 7 2017, 11:28 AM

graphics/drawpile/Makefile
23	^ nope :)

Harbormaster completed remote builds in B13405: Diff 36343.Dec 7 2017, 4:30 PM

tcberner added inline comments.Dec 7 2017, 5:18 PM

graphics/drawpile/pkg-plist
15	^ are these drawpile/drawpile paths correct?

tcberner added inline comments.Dec 7 2017, 5:22 PM

graphics/drawpile/Makefile
38	^ you should not have to manually compress man pages

yuri marked 2 inline comments as done.Dec 7 2017, 5:28 PM

yuri added inline comments.

graphics/drawpile/Makefile
38	They install them uncompressed. Do you think I should patch it in cmake and use `INSTALL_MAN` instead? This is going to require more lines in the port.
graphics/drawpile/pkg-plist
15	That's what they use. .svg files and translations certainly work.

yuri marked 4 inline comments as done.Dec 7 2017, 5:28 PM

As it installs to the normal path it should be compressed automatically.

Made manpage to be automatically compressed.

Harbormaster completed remote builds in B13406: Diff 36345.Dec 7 2017, 6:11 PM

In D13404#280141, @tcberner wrote:

As it installs to the normal path it should be compressed automatically.

This looks like a bug in cmake that this INSTALL(FILES ${man1} DESTINATION "man/man1") installs uncompressed manpages.

mat added inline comments.Dec 7 2017, 11:22 PM

graphics/drawpile/Makefile
38	You are missing the point, the framework will automatically compress man pages you do not need to do it yourself.

yuri marked an inline comment as done.Dec 8 2017, 1:55 AM

yuri added inline comments.

graphics/drawpile/Makefile
38	Thanks! I didn't realize this.

yuri marked 2 inline comments as done.Dec 8 2017, 6:49 PM

@tcberner Tobias, can this be committed?

It can indeed =)

This revision is now accepted and ready to land.Dec 10 2017, 2:38 PM

Closed by commit rP455903: New port: graphics/drawpile: Collaborative drawing program (authored by yuri). · Explain WhyDec 10 2017, 5:39 PM

This revision was automatically updated to reflect the committed changes.

New port: graphics/drawpile: Collaborative drawing program
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 36345

graphics/Makefile

graphics/drawpile/

graphics/drawpile/Makefile

graphics/drawpile/distinfo

graphics/drawpile/files/

graphics/drawpile/files/patch-desktop_CMakeLists.txt

graphics/drawpile/files/patch-doc_CMakeLists.txt

graphics/drawpile/pkg-descr

graphics/drawpile/pkg-plist

New port: graphics/drawpile: Collaborative drawing programClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36345

graphics/Makefile

graphics/drawpile/

graphics/drawpile/Makefile

graphics/drawpile/distinfo

graphics/drawpile/files/

graphics/drawpile/files/patch-desktop_CMakeLists.txt

graphics/drawpile/files/patch-doc_CMakeLists.txt

graphics/drawpile/pkg-descr

graphics/drawpile/pkg-plist

New port: graphics/drawpile: Collaborative drawing program
ClosedPublic
Actions

Revision Contents
Changeset List