Page MenuHomeFreeBSD

New port: graphics/drawpile: Collaborative drawing program
ClosedPublic

Authored by yuri on Dec 7 2017, 6:20 AM.
Tags
None
Referenced Files
F84182086: D13404.id.diff
Mon, May 20, 12:26 PM
F84182079: D13404.id36372.diff
Mon, May 20, 12:26 PM
F84182073: D13404.id36424.diff
Mon, May 20, 12:26 PM
F84182068: D13404.id36343.diff
Mon, May 20, 12:26 PM
F84182063: D13404.id36345.diff
Mon, May 20, 12:26 PM
F84182055: D13404.id36332.diff
Mon, May 20, 12:26 PM
Unknown Object (File)
Fri, May 17, 10:40 AM
Unknown Object (File)
Sat, May 4, 10:21 PM
Subscribers

Details

Summary

Collaborative drawing program

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

graphics/drawpile/Makefile
22 ↗(On Diff #36332)

^ nope :)

yuri marked an inline comment as done.

.

graphics/drawpile/pkg-plist
14 ↗(On Diff #36343)

^ are these drawpile/drawpile paths correct?

graphics/drawpile/Makefile
37 ↗(On Diff #36343)

^ you should not have to manually compress man pages

yuri marked 2 inline comments as done.Dec 7 2017, 5:28 PM
yuri added inline comments.
graphics/drawpile/Makefile
37 ↗(On Diff #36343)

They install them uncompressed. Do you think I should patch it in cmake and use INSTALL_MAN instead? This is going to require more lines in the port.

graphics/drawpile/pkg-plist
14 ↗(On Diff #36343)

That's what they use. .svg files and translations certainly work.

yuri marked 4 inline comments as done.Dec 7 2017, 5:28 PM

As it installs to the normal path it should be compressed automatically.

Made manpage to be automatically compressed.

As it installs to the normal path it should be compressed automatically.

This looks like a bug in cmake that this INSTALL(FILES ${man1} DESTINATION "man/man1") installs uncompressed manpages.

graphics/drawpile/Makefile
37 ↗(On Diff #36343)

You are missing the point, the framework will automatically compress man pages you do not need to do it yourself.

yuri marked an inline comment as done.Dec 8 2017, 1:55 AM
yuri added inline comments.
graphics/drawpile/Makefile
37 ↗(On Diff #36343)

Thanks! I didn't realize this.

yuri marked 2 inline comments as done.Dec 8 2017, 6:49 PM
This revision is now accepted and ready to land.Dec 10 2017, 2:38 PM
This revision was automatically updated to reflect the committed changes.