Page MenuHomeFreeBSD

New port: graphics/drawpile: Collaborative drawing program
ClosedPublic

Authored by yuri on Dec 7 2017, 6:20 AM.
Tags
None
Referenced Files
F81657195: D13404.diff
Fri, Apr 19, 1:46 PM
Unknown Object (File)
Mar 21 2024, 4:58 AM
Unknown Object (File)
Feb 14 2024, 11:28 AM
Unknown Object (File)
Feb 12 2024, 2:40 AM
Unknown Object (File)
Feb 12 2024, 2:40 AM
Unknown Object (File)
Feb 12 2024, 2:40 AM
Unknown Object (File)
Feb 12 2024, 2:40 AM
Unknown Object (File)
Feb 12 2024, 2:40 AM
Subscribers

Details

Summary

Collaborative drawing program

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13427
Build 13657: arc lint + arc unit

Event Timeline

graphics/drawpile/Makefile
23

^ nope :)

yuri marked an inline comment as done.

.

graphics/drawpile/pkg-plist
15

^ are these drawpile/drawpile paths correct?

graphics/drawpile/Makefile
38

^ you should not have to manually compress man pages

yuri marked 2 inline comments as done.Dec 7 2017, 5:28 PM
yuri added inline comments.
graphics/drawpile/Makefile
38

They install them uncompressed. Do you think I should patch it in cmake and use INSTALL_MAN instead? This is going to require more lines in the port.

graphics/drawpile/pkg-plist
15

That's what they use. .svg files and translations certainly work.

yuri marked 4 inline comments as done.Dec 7 2017, 5:28 PM

As it installs to the normal path it should be compressed automatically.

Made manpage to be automatically compressed.

As it installs to the normal path it should be compressed automatically.

This looks like a bug in cmake that this INSTALL(FILES ${man1} DESTINATION "man/man1") installs uncompressed manpages.

graphics/drawpile/Makefile
38

You are missing the point, the framework will automatically compress man pages you do not need to do it yourself.

yuri marked an inline comment as done.Dec 8 2017, 1:55 AM
yuri added inline comments.
graphics/drawpile/Makefile
38

Thanks! I didn't realize this.

yuri marked 2 inline comments as done.Dec 8 2017, 6:49 PM
This revision is now accepted and ready to land.Dec 10 2017, 2:38 PM
This revision was automatically updated to reflect the committed changes.