devfs: Remove devfs_pathpath
AbandonedPublic
Actions

Authored by manu on Dec 6 2017, 1:39 PM.

Details

Reviewers

kib
pfg
bapt

Summary

devfs_pathpath test if the new device name will conflict with an existing
device name or directory.
Instead of using this, register every directory in devfs_dir and simply
strcmp the device we want to add with existing devices and directories.

Sponsored-By: Gandi.net
MFC After: 1 month

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Dec 6 2017, 1:39 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 6 2017, 1:39 PM

manu added a child revision: D13395: devfs: Add siphash comparison.Dec 6 2017, 1:43 PM

kib added inline comments.Dec 6 2017, 3:17 PM

sys/fs/devfs/devfs_devs.c
591	This is too late, adding the intermediate directories path into the global registry at the populate_loop() allows for two conflicting types of the same name to be created.
593	This line must be merged with the previous line, according to style(9).
706	There are many whitespace changes unrelated to the patch' subject.

manu added inline comments.Dec 6 2017, 3:47 PM

sys/fs/devfs/devfs_devs.c
591	Ah yes I see that now, I'll see what I can do.
706	Yes sorry, I did some whitespace cleanup at the same time, I'll commit those non-functional changes and rebase this diff.