Page MenuHomeFreeBSD

php*-fastdfs: remove hard-code patching
ClosedPublic

Authored by joneum on Nov 17 2017, 8:47 PM.
Tags
None
Referenced Files
F151700553: D13137.id35390.diff
Fri, Apr 10, 3:03 AM
F151652214: D13137.id35738.diff
Thu, Apr 9, 7:10 PM
F151648955: D13137.id35390.diff
Thu, Apr 9, 6:45 PM
Unknown Object (File)
Sat, Apr 4, 6:38 AM
Unknown Object (File)
Sat, Mar 28, 6:27 AM
Unknown Object (File)
Fri, Mar 27, 7:28 PM
Unknown Object (File)
Thu, Mar 26, 2:48 AM
Unknown Object (File)
Wed, Mar 25, 9:43 AM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13031
Build 13285: arc lint + arc unit

Event Timeline

You probably should not change to DISTVERSION here, as that is the only change to the line

As these set PHP_VER, I do not think they need the IGNORE_WITH_PHP variable, it is useless. (Because what is in PHP_VER is used to check if IGNORE_WITH_PHP matches, so it will never match.)

switch back to PORTVERSION, remove PHP ignore

Ok, I think this is a good first step for these ports.

The next one is to see how you can combine them nicely into one like @tz suggested in revision D13123 :)

Unless @tz has anything to add for now, this seems fine.

This revision is now accepted and ready to land.Nov 24 2017, 11:05 PM
This revision was automatically updated to reflect the committed changes.