Add r-ccu support for the Allwinner a83t
ClosedPublic
Actions

Authored by kevans on Nov 23 2017, 6:29 AM.

Details

Reviewers

manu
emaste

Commits

rS326190: Add r-ccu support for the Allwinner a83t

Summary

The r-ccu on the a83t differs from the others only by what it names the ar100 parents. Export the _CCU macros so ccu_sun8i_r can differentiate between a83t r-ccu and the others, add the compat string for the a83t r-ccu.

NOTE: As far as I can tell, this is the only difference

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 12987

Event Timeline

kevans created this revision.Nov 23 2017, 6:29 AM

Herald added subscribers: andrew, imp. · View Herald TranscriptNov 23 2017, 6:29 AM

Note: This patch is against -HEAD + D13205.

manu added inline comments.Nov 23 2017, 6:58 AM

sys/arm/allwinner/clkng/aw_ccung.h
33	I prefer that every consumer include this file instead of relying on header pollution.
sys/arm/allwinner/clkng/ccu_sun8i_r.c
146	I'd rather keep the array as all those register_clocks function are the same I'll merge them into one one day.

Unconditionally define the *_CCU macros in aw_ccung.h; maintain array-based clock approach in ccu_sun8i_r

manu added inline comments.Nov 24 2017, 7:02 PM

sys/arm/allwinner/clkng/aw_ccung.h
40	We should do an enum instead if we always define them.

kevans added inline comments.Nov 24 2017, 8:00 PM

sys/arm/allwinner/clkng/aw_ccung.h
40	nod Do we have a preference on explicitly defining only the first item in the enum vs. explicitly defining all of them?

manu added inline comments.Nov 24 2017, 8:45 PM

sys/arm/allwinner/clkng/aw_ccung.h
40	IIRC style(9) say that we only need to define the first.

Convert to an enum; I ultimately couldn't find anything explicit or implicit in style(9) about it, but we do only define the first in other parts of arm/allwinner so it fits the area.

I was going to go a step further and convert sc->type, but quickly realized that would break down and force us to move all of the individual *_ccu inclusions up into global allwinner stuff or create an even nastier typedef mess in aw_ccung.c

manu accepted this revision.Nov 25 2017, 11:56 AM

This revision is now accepted and ready to land.Nov 25 2017, 11:56 AM

Closed by commit rS326190: Add r-ccu support for the Allwinner a83t (authored by kevans). · Explain WhyNov 25 2017, 3:15 PM

This revision was automatically updated to reflect the committed changes.