Page MenuHomeFreeBSD
Differential D13202

textproc/fcitx-qt5: Update to 1.2.1
ClosedPublic
Actions

Authored by yuri on Nov 22 2017, 11:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 12, 7:55 AM
Unknown Object (File)
Fri, Apr 10, 3:18 PM
Unknown Object (File)
Wed, Apr 8, 2:55 PM
Unknown Object (File)
Wed, Apr 8, 2:53 AM
Unknown Object (File)
Sun, Apr 5, 12:40 AM
Unknown Object (File)
Thu, Apr 2, 8:41 AM
Unknown Object (File)
Wed, Apr 1, 10:50 PM
Unknown Object (File)
Wed, Apr 1, 4:22 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP454741: textproc/fcitx-qt5: Update to 1.2.1
Summary

Simple update.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12962
Build 13220: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 22 2017, 11:31 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 22 2017, 11:31 PM
Harbormaster completed remote builds in B12956: Diff 35623.Nov 22 2017, 11:31 PM
yuri updated this revision to Diff 35624.Nov 22 2017, 11:52 PM

.

Harbormaster completed remote builds in B12957: Diff 35624.Nov 22 2017, 11:52 PM
tcberner added inline comments.Nov 23 2017, 5:39 AM
textproc/fcitx-qt5/Makefile
20

^ qmake_build should suffice

yuri updated this revision to Diff 35631.Nov 23 2017, 5:51 AM

.

yuri marked an inline comment as done.Nov 23 2017, 5:51 AM
yuri added inline comments.
textproc/fcitx-qt5/Makefile
20

Indeed. -)

yuri marked 2 inline comments as done.Nov 23 2017, 5:51 AM
tcberner added inline comments.Nov 23 2017, 5:58 AM
textproc/fcitx-qt5/Makefile
16

^ drop gettext

23

^ NLS_USES=gettext

23

^ not here, but near NLS_CMAKE_BOOL ^^

yuri updated this revision to Diff 35634.Nov 23 2017, 6:12 AM
yuri marked 3 inline comments as done.

.

Harbormaster completed remote builds in B12963: Diff 35634.Nov 23 2017, 6:12 AM
yuri added inline comments.Nov 23 2017, 6:12 AM
textproc/fcitx-qt5/Makefile
16

cmake's NLS doesn't cleanly disable gettext. I added it with a patch, but it was incomplete. I rolled it back, and asked them to implement it: https://github.com/fcitx/fcitx-qt5/issues/29

yuri marked an inline comment as done.Nov 23 2017, 6:12 AM
tcberner accepted this revision.Nov 23 2017, 6:31 AM

Looks ok.

This revision is now accepted and ready to land.Nov 23 2017, 6:31 AM
Closed by commit rP454741: textproc/fcitx-qt5: Update to 1.2.1 (authored by yuri). · Explain WhyNov 23 2017, 6:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
textproc/
fcitx-qt5/
11 lines
6 lines
files/
13 lines
2 lines
15 lines

Diff 35631

View Options

textproc/fcitx-qt5/Makefile

Loading...
View Options

textproc/fcitx-qt5/distinfo

Loading...
View Options

textproc/fcitx-qt5/files/patch-CMakeLists.txt

Loading...
View Options

textproc/fcitx-qt5/files/patch-widgetsaddons_CMakeLists.txt

Loading...
View Options

textproc/fcitx-qt5/pkg-plist

Loading...